[release/v7.5.6] Download PMC Packages through TemplateContext#27335
Conversation
Co-authored-by: Justin Chung <chungjustin@microsoft.com>
daxian-dbw
added
the
CL-BuildPackaging
There was a problem hiding this comment.
Pull request overview
Backports a release pipeline update to unblock PMC (packages.microsoft.com) publishing by switching artifact downloads to OneBranch templateContext.inputs (avoiding disallowed DownloadArtifacts/DownloadPipelineArtifact usage in the EV2 environment).
Changes:
- Refactors
release-prep-for-ev2.ymlandrelease-publish-pmc.ymlto download required pipeline artifacts viatemplateContext.inputs. - Parameterizes the PMC publish stage (environment/prefix) and adds a
skipEv2Pushmode to support NonOfficial dry-run validation. - Updates Official/NonOfficial Azure release pipelines to run with the new templates (and adds the publish-stage dry-run in NonOfficial).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| EndpointProviderType: ApprovalService | ||
| ApprovalServiceEnvironment: ${{ parameters.approvalServiceEnvironment }} | ||
| ServiceRootPath: '$(Pipeline.Workspace)/EV2Specs/ServiceGroupRoot' | ||
| RolloutSpecPath: '$(Pipeline.Workspace)/EV2Specs/ServiceGroupRoot/RolloutSpec.json' |
There was a problem hiding this comment.
When skipEv2Push is true, the compile-time if removes the only step, leaving the job with effectively no steps. This makes the NonOfficial dry-run path unable to actually validate the templateContext.inputs download (and may be rejected by the pipeline engine if it requires at least one step). Consider adding an else branch step that at least enumerates $(Pipeline.Workspace) (or a simple no-op script) so the job always has a step and the download is exercised.
Backport of #27326 to release/v7.5.6
Triggered by @daxian-dbw on behalf of @jshigetomi
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
This backports the Azure pipeline fix that refactors artifact download steps to use
templateContext.inputsin the PMC release pipeline. This is required to unblock PMC releases on the v7.5.6 release branch, as the EV2 pipeline no longer allows the DownloadArtifacts task.Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
The original PR was validated as part of fixing the 7.4.15 and 7.6.1 PMC releases (PRs #27330 and #27331 which have been merged). This cherry-pick applied cleanly with no conflicts. Pipeline changes are validated when the release pipeline runs against the release branch.
Risk
REQUIRED: Check exactly one box.
This is a build/release pipeline YAML change only — no product code or runtime behavior is modified. The same fix has already been successfully applied and merged to the v7.4.15 and v7.6.1 release branches (PRs #27330 and #27331).