Correct Variable Template Reference in NonOfficial Pipeline Templates by jshigetomi · Pull Request #27275 · PowerShell/PowerShell · GitHub
Skip to content

Correct Variable Template Reference in NonOfficial Pipeline Templates#27275

Merged
jshigetomi merged 9 commits intoPowerShell:masterfrom
jshigetomi:nonOfficialPipelinesFix
Apr 21, 2026
Merged

Correct Variable Template Reference in NonOfficial Pipeline Templates#27275
jshigetomi merged 9 commits intoPowerShell:masterfrom
jshigetomi:nonOfficialPipelinesFix

Conversation

@jshigetomi
Copy link
Copy Markdown
Collaborator

@jshigetomi jshigetomi commented Apr 15, 2026

PR Summary

This pull request updates documentation and several ADO pipeline YAML files to standardize the use of the .pipelines directory and corrects relative paths for template imports. The changes ensure consistency between documentation and implementation, and fix broken template references in NonOfficial pipeline YAML files.

Documentation updates:

  • Updated all references in .github/agents/SplitADOPipelines.agent.md from ./pipelines to .pipelines to match the actual directory structure and improve clarity in instructions. [1] [2] [3] [4] [5] [6]

Pipeline YAML fixes:

  • Corrected template paths in all NonOfficial pipeline YAML files under .pipelines/NonOfficial/ to use ../templates/ instead of ./pipelines/templates/, ensuring the templates are correctly referenced relative to their location. [1] [2] [3] [4] [5] [6] [7] [8] [9]

PR Context

NonOfficial pipelines will not run without this fix.

PR Checklist

@jshigetomi jshigetomi added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 15, 2026
@azure-pipelines
Copy link
Copy Markdown

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
5 pipeline(s) require an authorized user to comment /azp run to run.

@jshigetomi jshigetomi marked this pull request as ready for review April 16, 2026 16:12
@jshigetomi jshigetomi requested a review from a team as a code owner April 16, 2026 16:12
Copilot AI review requested due to automatic review settings April 16, 2026 16:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes references to the .pipelines directory and fixes broken Azure DevOps YAML template imports for NonOfficial pipelines by correcting their relative template paths.

Changes:

  • Update NonOfficial pipeline YAMLs under .pipelines/NonOfficial/ to import templates via ../templates/... instead of the invalid ./pipelines/templates/... paths.
  • Update .github/agents/SplitADOPipelines.agent.md documentation to reference .pipelines (not ./pipelines) for the repository pipeline directory.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
.pipelines/NonOfficial/PowerShell-vPack-NonOfficial.yml Fix variables/stages template import paths to point at .pipelines/templates correctly.
.pipelines/NonOfficial/PowerShell-Release-NonOfficial.yml Fix variables/stages template import paths to point at .pipelines/templates correctly.
.pipelines/NonOfficial/PowerShell-Release-Azure-NonOfficial.yml Fix variables template import path to point at .pipelines/templates correctly.
.pipelines/NonOfficial/PowerShell-Packages-NonOfficial.yml Fix variables/stages template import paths to point at .pipelines/templates correctly.
.pipelines/NonOfficial/PowerShell-Coordinated_Packages-NonOfficial.yml Fix variables/stages template import paths; aligns WindowsHostVersion settings with the Official pipeline.
.github/agents/SplitADOPipelines.agent.md Update documentation to refer to .pipelines instead of ./pipelines (but examples still need path/name alignment—see comments).

Comment thread .github/agents/SplitADOPipelines.agent.md Outdated
Comment thread .github/agents/SplitADOPipelines.agent.md Outdated
Comment thread .github/agents/SplitADOPipelines.agent.md Outdated
Comment thread .github/agents/SplitADOPipelines.agent.md Outdated
Justin Chung added 3 commits April 21, 2026 15:03
- Use templates/variables/ and templates/stages/ subfolders in examples
- Use *-Official.yml naming in examples
- Addresses Copilot comments on PR PowerShell#27275
Comment thread .pipelines/NonOfficial/PowerShell-vPack-NonOfficial.yml Outdated
Justin Chung added 2 commits April 21, 2026 15:13
Normalize variables/ and stages/ includes to /.pipelines/templates/...@self to match the dominant convention in the repo and avoid breakage if the files are ever moved.
…te refs

Adds a top-level 'Template Reference Convention' section and updates every example in Steps 2, 3, and 5 to use /.pipelines/templates/...@self so the agent's output matches the in-repo convention and avoids relative-path resolution bugs.
@jshigetomi jshigetomi merged commit d50bc2c into PowerShell:master Apr 21, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.4.x-Consider Backport-7.5.x-Consider CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants