{{ message }}
Adding -Extension and -LeafBase switches to Split-Path#2721
Merged
daxian-dbw merged 3 commits intoPowerShell:masterfrom Mar 11, 2017
Merged
Adding -Extension and -LeafBase switches to Split-Path#2721daxian-dbw merged 3 commits intoPowerShell:masterfrom
daxian-dbw merged 3 commits intoPowerShell:masterfrom
Conversation
powercode
changed the title
powercode
force-pushed
the
split-path-switches
branch
from
fd24ea2 to
e8e7f40
Compare
Collaborator
There was a problem hiding this comment.
should there be explicit tests for things like:
"$level2_1Full$fileExt$fileExt"
to ensure that the trimming is not over-zealous?
powercode
force-pushed
the
split-path-switches
branch
from
e8e7f40 to
ef0abc9
Compare
charub
reviewed
Mar 3, 2017
Contributor
There was a problem hiding this comment.
What's the difference between LeafSet and LeafBaseSet?
charub
reviewed
Mar 3, 2017
Contributor
There was a problem hiding this comment.
The comment seems to be duplicated.
charub
reviewed
Mar 3, 2017
Contributor
There was a problem hiding this comment.
The default value of _parent used to be true. The default for a switch is False. Please revisit.
Collaborator
Author
There was a problem hiding this comment.
Good catch. Fixing and rebasing.
added 3 commits
March 3, 2017 22:34
…No functionallity changes Using auto properties when no when there is no logic in getter/setter Removing unused code Removing redundant qualifiers Removing Redundant initializers
Extension and LeafBase are specializations of Leaf, and uses System.IO.Path.GetExtension and System.IO.Path.GetFilenameWithoutExtension to extract parts from the Leaf
powercode
force-pushed
the
split-path-switches
branch
from
ef0abc9 to
33e266e
Compare
Member
daxian-dbw
approved these changes
Mar 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2700
Extension and LeafBase are specializations of Leaf, and uses System.IO.Path.GetExtension
and System.IO.Path.GetFilenameWithoutExtension to extract parts from the Leaf
Tests added in test\powershell\Modules\Microsoft.PowerShell.Management\FileSystem.Tests.ps1