[release/v7.5.6] Move `_GetDependencies` MSBuild target from dynamic generation in `build.psm1` into `Microsoft.PowerShell.SDK.csproj` by adityapatwardhan · Pull Request #27164 · PowerShell/PowerShell · GitHub
Skip to content

[release/v7.5.6] Move _GetDependencies MSBuild target from dynamic generation in build.psm1 into Microsoft.PowerShell.SDK.csproj#27164

Merged
adityapatwardhan merged 1 commit intoPowerShell:release/v7.5.6from
adityapatwardhan:backport/release/v7.5.6/27052-569eb7246
Apr 3, 2026
Merged

[release/v7.5.6] Move _GetDependencies MSBuild target from dynamic generation in build.psm1 into Microsoft.PowerShell.SDK.csproj#27164
adityapatwardhan merged 1 commit intoPowerShell:release/v7.5.6from
adityapatwardhan:backport/release/v7.5.6/27052-569eb7246

Conversation

@adityapatwardhan
Copy link
Copy Markdown
Member

Backport of #27052 to release/v7.5.6

Triggered by @adityapatwardhan on behalf of @app/copilot-swe-agent

Original CL Label: CL-BuildPackaging

/cc @PowerShell/powershell-maintainers

Impact

REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Ensures the SDK project carries the _GetDependencies target directly on the release/v7.5.6 branch and keeps Start-TypeGen native execution handling consistent for build tooling reliability.

Customer Impact

  • Customer reported
  • Found internally

Regression

REQUIRED: Check exactly one box.

  • Yes
  • No

This is not a regression.

Testing

Cherry-pick applied cleanly with no merge conflicts; this backport preserves the already-validated change from main and is scoped to build/type generation plumbing in build.psm1 and Microsoft.PowerShell.SDK.csproj.

Risk

REQUIRED: Check exactly one box.

  • High
  • Medium
  • Low

Low risk because this is a focused build-system maintenance change already merged on main, with no runtime feature behavior changes and no additional conflict resolution needed.

…ild.psm1` into `Microsoft.PowerShell.SDK.csproj` (PowerShell#27052)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 2, 2026
Copilot AI review requested due to automatic review settings April 2, 2026 21:30
@adityapatwardhan adityapatwardhan requested a review from a team as a code owner April 2, 2026 21:30
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Backports the main-branch change to make the _GetDependencies MSBuild target a first-class part of the Microsoft.PowerShell.SDK project, simplifying Start-TypeGen and improving native command failure handling in the build tooling on the release/v7.5.6 branch.

Changes:

  • Added the _GetDependencies MSBuild target directly to src/Microsoft.PowerShell.SDK/Microsoft.PowerShell.SDK.csproj.
  • Removed dynamic .targets file generation from Start-TypeGen in build.psm1.
  • Wrapped dotnet msbuild and dotnet run in Start-NativeExecution for consistent exit-code/error handling.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Microsoft.PowerShell.SDK/Microsoft.PowerShell.SDK.csproj Adds the _GetDependencies target used by Start-TypeGen to collect reference assembly paths for TypeCatalog generation.
build.psm1 Simplifies Start-TypeGen by removing target-file generation and standardizing native invocations via Start-NativeExecution.

@adityapatwardhan adityapatwardhan merged commit b74f0c6 into PowerShell:release/v7.5.6 Apr 3, 2026
44 checks passed
@adityapatwardhan adityapatwardhan deleted the backport/release/v7.5.6/27052-569eb7246 branch April 3, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants