[release/v7.4] Hardcode Official templates (#26928) by jshigetomi · Pull Request #26962 · PowerShell/PowerShell · GitHub
Skip to content

[release/v7.4] Hardcode Official templates (#26928)#26962

Merged
jshigetomi merged 1 commit intoPowerShell:release/v7.4.14from
jshigetomi:backport-26956
Mar 9, 2026
Merged

[release/v7.4] Hardcode Official templates (#26928)#26962
jshigetomi merged 1 commit intoPowerShell:release/v7.4.14from
jshigetomi:backport-26956

Conversation

@jshigetomi
Copy link
Copy Markdown
Collaborator

@jshigetomi jshigetomi commented Mar 9, 2026

Backport #26956

@jshigetomi jshigetomi added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 9, 2026
@jshigetomi jshigetomi marked this pull request as ready for review March 9, 2026 19:21
@jshigetomi jshigetomi requested a review from a team as a code owner March 9, 2026 19:21
Copilot AI review requested due to automatic review settings March 9, 2026 19:21
Copilot AI reviewed Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR backports the change to hardcode OneBranch Official governed templates in the release/v7.4 “Official” Azure Pipelines definitions, removing the queue-time OfficialBuild switch and forcing Production/Official template paths.

Changes:

  • Remove the OfficialBuild boolean parameter and associated conditional template selection in multiple “Official” pipelines.
  • Hardcode pipeline naming to include prod.true and hardcode extends.template to the Official OneBranch templates.
  • In the coordinated binaries pipeline, add a FORCE_CODEQL parameter and set related variables while also forcing ps_official_build: true.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.pipelines/PowerShell-vPack-Official.yml Removes OfficialBuild parameter and hardcodes Official governed template usage.
.pipelines/PowerShell-Release-Official.yml Forces Production/Official template and removes OfficialBuild toggle.
.pipelines/PowerShell-Release-Official-Azure.yml Forces Official template and removes OfficialBuild toggle.
.pipelines/PowerShell-Packages-Official.yml Forces Official template usage and hardcodes OfficialBuild: true when invoking MSIX bundle creation template.
.pipelines/PowerShell-Coordinated_Packages-Official.yml Forces Official template usage, forces ps_official_build: true, and introduces FORCE_CODEQL parameter/variables.

Comment thread .pipelines/PowerShell-Coordinated_Packages-Official.yml
Comment on lines +82 to +86
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FORCE_CODEQL is described as enabling CodeQL, but this pipeline only sets CodeQL.Cadence/CODEQL_ENABLED here; the build templates it invokes (e.g. .pipelines/templates/windows-hosted-build.yml and linux.yml) gate CodeQL3000Init/Finalize strictly on Build.SourceBranch == refs/heads/master. That means FORCE_CODEQL: true won’t actually enable CodeQL runs on non-master branches. Consider wiring the CodeQL task conditions in those templates to variables['CODEQL_ENABLED'] (or similar), or rename/remove this parameter to avoid implying behavior it can’t provide.

Copilot uses AI. Check for mistakes.
@jshigetomi jshigetomi merged commit 2a4949b into PowerShell:release/v7.4.14 Mar 9, 2026
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@daxian-dbw daxian-dbw daxian-dbw approved these changes

Assignees

No one assigned

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jshigetomi @daxian-dbw