{{ message }}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
packagingChangedoutput is not set in the path-filters action for non-PR events (push tomaster,release/**, etc.). On push events, the action only setstoolsChanged,githubChanged,propsChanged,testsChanged,mainSourceChanged,buildModuleChanged, andsource— but NOTpackagingChanged(see.github/actions/infrastructure/path-filters/action.ymllines 50-61). This means the macOS packaging job will never run on push events.Previously, this job used
source == 'true' || buildModuleChanged == 'true', which worked on push events since bothsourceandbuildModuleChangedare set totruefor non-PR events.Note: This same issue already affects
linux_packaginginlinux-ci.ymlandwindows_packaginginwindows-ci.ymlwhich also usepackagingChanged. This should be fixed in the default branch first by addingpackagingChangedto the non-PR outputs in the path-filters action.Suggested Issue for Default Branch:
Issue Title
path-filters action does not set
packagingChangedoutput for non-PR (push) eventsDescription
The path-filters composite action at
.github/actions/infrastructure/path-filters/action.ymlhas a fast path for non-PR events (lines 50-61) that sets all outputs totrue, butpackagingChangedis missing from this block.Current State:
packagingChangedis never set (empty/falsy)packagingChanged == 'true'masterorrelease/**branchesExpected State:
Add
core.setOutput('packagingChanged', true);to the non-PR block alongside the other outputs.Files Affected:
.github/actions/infrastructure/path-filters/action.ymlPriority: High
Labels:
Issue-Bug,Area-Build