{{ message }}
Replace Hashtable with HashSet#25918
Open
xtqqczze wants to merge 1 commit into
Open
Conversation
xtqqczze
changed the title
Hashtable with HashSet in helpHashtable with HashSet
iSazonov
approved these changes
Aug 29, 2025
iSazonov
added
the
CL-CodeCleanup
Collaborator
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Collaborator
|
@daxian-dbw Could you please merge? |
microsoft-github-policy-service
Bot
added
the
Review - Needed
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the codebase by replacing non-generic Hashtable collections with generic HashSet<string> in help provider classes. This change improves type safety and follows modern C# best practices.
- Replaces
HashtablewithHashSet<string>for tracking loaded help files - Updates corresponding API calls from hashtable indexing to
HashSet.Add()andHashSet.Contains() - Removes unnecessary
System.Collectionsimports
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace non-generic
HashtablewithHashSetinsrc/System.Management.Automation/help/.Related: #12958