iframe-proxy

daxian-dbw · 2022-07-13T01:04:31Z

PR Summary

The 7.0.10 release contains a commit for a potential security issue: 38e55e1. Here is the announcement about it: PowerShell/Announcements#31.

This particular change from that commit caused a regression in Azure Function when running Import-Module <module-name> -UseWindowsPowerShell, where the user's module path doesn't exist. That command worked fine with the PowerShell 7.0.9 SDK but started to fail with the PowerShell 7.0.11 SDK.

The root cause is that when Export-PSSession is used by Import-Module -UseWindowsPowerShell, a rooted path is always specified to the -OutputModule parameter, so it doesn't matter whether the user's module path exists or not because it doesn't need it to identify the directory to use.

The fix is to use the specified rooted path directly. Actually, Path.Combine(path1, path2) will return path2 if it's rooted.
The error message is also updated:

PR Checklist

…ed for -OutputModule

Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>

pull-request-quantifier-deprecated · 2022-07-13T17:58:42Z

This PR has 26 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Small
Size       : +15 -11
Percentile : 10.4%

Total files changed: 2

Change summary by file extension:
.resx : +1 -1
.cs : +14 -10

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detetcted.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

iSazonov · 2022-07-14T04:38:05Z

It makes sense for PowerShell Committee to review OutModule parameter. I think the case is the same as #3174 (#11701) - OutModule parameter should be LiteralPath. If so we could simplify CreateModuleDirectory() method.

ghost · 2022-07-18T21:43:22Z

🎉v7.3.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

adityapatwardhan · 2022-08-02T19:43:25Z

/backport release/v7.2.6

adityapatwardhan · 2022-08-02T19:45:15Z

/backport to release/v7.0.12

github-actions · 2022-08-02T19:45:32Z

Started backporting to release/v7.0.12: https://github.com/PowerShell/PowerShell/actions/runs/2784794011

GitHub
Fix `Export-PSSession` to not throw error when a rooted path is specified for `-OutputModule` · PowerShell/PowerShell@0e4d2e4
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

adityapatwardhan · 2022-08-02T19:45:45Z

/backport to release/v7.2.6

github-actions · 2022-08-02T19:45:55Z

@adityapatwardhan backporting to release/v7.0.12 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix Export-PSSession to not throw error when a rooted path is specified for -OutputModule
Applying: Update comment
error: sha1 information is lacking or useless (src/System.Management.Automation/utils/PathUtils.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Update comment
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

github-actions · 2022-08-02T19:45:59Z

Started backporting to release/v7.2.6: https://github.com/PowerShell/PowerShell/actions/runs/2784796745

GitHub
Fix `Export-PSSession` to not throw error when a rooted path is specified for `-OutputModule` · PowerShell/PowerShell@0e4d2e4
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

ghost · 2022-08-11T22:15:50Z

🎉v7.0.12 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

ghost · 2022-08-11T22:18:52Z

Fix Export-PSSession to not throw error when a rooted path is specifi…

5a010b7

…ed for -OutputModule

ghost assigned adityapatwardhan Jul 13, 2022

daxian-dbw requested a review from SteveL-MSFT July 13, 2022 01:04

daxian-dbw assigned daxian-dbw and unassigned adityapatwardhan Jul 13, 2022

daxian-dbw requested a review from anmenaga July 13, 2022 01:05

daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jul 13, 2022

pull-request-quantifier-deprecated Bot added the Extra Small label Jul 13, 2022

SteveL-MSFT reviewed Jul 13, 2022

View reviewed changes

Comment thread src/System.Management.Automation/utils/PathUtils.cs

TravisEz13 added BackPort-7.0.x-Consider labels Jul 13, 2022

TravisEz13 approved these changes Jul 13, 2022

View reviewed changes

PaulHigin suggested changes Jul 13, 2022

View reviewed changes

Comment thread src/System.Management.Automation/utils/PathUtils.cs

ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jul 13, 2022

Update comment

8a13b41

adityapatwardhan reviewed Jul 13, 2022

View reviewed changes

Comment thread src/System.Management.Automation/utils/PathUtils.cs Outdated

Update src/System.Management.Automation/utils/PathUtils.cs

0610f43

Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>

PaulHigin approved these changes Jul 13, 2022

View reviewed changes

SteveL-MSFT approved these changes Jul 13, 2022

View reviewed changes

adityapatwardhan approved these changes Jul 13, 2022

View reviewed changes

daxian-dbw merged commit f9d424d into PowerShell:master Jul 13, 2022

daxian-dbw deleted the usewindows branch July 13, 2022 20:32

Francisco-Gamino mentioned this pull request Jul 14, 2022

Failed to generate proxies for remote module 'AzureAD' using the latest PowerShell SDK 7.0.11 #17662

Closed

5 tasks

adityapatwardhan added BackPort-7.0.x-Approved and removed BackPort-7.0.x-Consider labels Aug 2, 2022

adityapatwardhan added the Backport-7.2.x-Approved label Aug 2, 2022

github-actions Bot mentioned this pull request Aug 2, 2022

[release/v7.2.6] Fix Export-PSSession to not throw error when a rooted path is specified for -OutputModule #17819

Merged

1 task

adityapatwardhan added Backport-7.2.x-Done Backport-7.0.x-Done and removed Backport-7.2.x-Approved labels Aug 5, 2022

TravisEz13 mentioned this pull request Sep 30, 2022

Move ApiScan to compliance build #18191

Merged

22 tasks

daxian-dbw mentioned this pull request May 8, 2023

Import-Module with UseWindowsPowerShell parameter as LOCALSYSTEM account fails if $HOME\Documents\Powershell\Modules directory does not exist. #17744

Closed

5 tasks

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

daxian-dbw commented Jul 13, 2022

PR Summary

PR Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pull-request-quantifier-deprecated Bot commented Jul 13, 2022

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

iSazonov commented Jul 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jul 18, 2022

Uh oh!

adityapatwardhan commented Aug 2, 2022

Uh oh!

adityapatwardhan commented Aug 2, 2022

Uh oh!

github-actions Bot commented Aug 2, 2022 • edited by unfurl-links Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adityapatwardhan commented Aug 2, 2022

Uh oh!

github-actions Bot commented Aug 2, 2022

Uh oh!

github-actions Bot commented Aug 2, 2022 • edited by unfurl-links Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Aug 11, 2022

Uh oh!

ghost commented Aug 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

iSazonov commented Jul 14, 2022 •

edited

Loading

github-actions Bot commented Aug 2, 2022 •

edited by unfurl-links Bot

Loading

github-actions Bot commented Aug 2, 2022 •

edited by unfurl-links Bot

Loading