Fix tab completion regression by MartinGC94 · Pull Request #17628 · PowerShell/PowerShell · GitHub
Skip to content

Fix tab completion regression#17628

Merged
iSazonov merged 4 commits intoPowerShell:masterfrom
MartinGC94:FixTabCompletionRegression
Jul 7, 2022
Merged

Fix tab completion regression#17628
iSazonov merged 4 commits intoPowerShell:masterfrom
MartinGC94:FixTabCompletionRegression

Conversation

@MartinGC94
Copy link
Copy Markdown
Contributor

PR Summary

Fixes an issue with tab completion when completing the second argument in a command like: Get-ChildItem -Path C:\ -ErrorAction <Tab> this was regression introduced in #17078 where I gave some wrong advice.
Also fixes a null reference error when completing in between 2 arguments, right after a comma like: Test-ValidateSet -Param1 Dog,<Tab> -Param2

PR Context

PR Checklist

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Outdated
MartinGC94 and others added 2 commits July 5, 2022 17:17
Co-authored-by: Ilya <darpa@yandex.ru>
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Outdated
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jul 7, 2022
@iSazonov iSazonov merged commit 81f4927 into PowerShell:master Jul 7, 2022
@iSazonov iSazonov assigned iSazonov and unassigned adityapatwardhan Jul 7, 2022
@MartinGC94 MartinGC94 deleted the FixTabCompletionRegression branch July 7, 2022 11:06
@ghost
Copy link
Copy Markdown

ghost commented Jul 18, 2022

@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants