Fix various completion issues inside the param block by MartinGC94 · Pull Request #17489 · PowerShell/PowerShell · GitHub
Skip to content

Fix various completion issues inside the param block#17489

Merged
iSazonov merged 1 commit intoPowerShell:masterfrom
MartinGC94:FixParamblockCompletion
Jun 9, 2022
Merged

Fix various completion issues inside the param block#17489
iSazonov merged 1 commit intoPowerShell:masterfrom
MartinGC94:FixParamblockCompletion

Conversation

@MartinGC94
Copy link
Copy Markdown
Contributor

PR Summary

Fixes #15300
This fix removes the unnamed block that implicitly surrounds the script from the relatedAsts list if it's the last item in the list.
Many completions have not been written with that block in mind so they don't work when completing an item inside the param block.

PR Context

PR Checklist

@pull-request-quantifier-deprecated
Copy link
Copy Markdown

@ghost ghost assigned iSazonov Jun 6, 2022
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jun 7, 2022
@iSazonov iSazonov merged commit 12a2c82 into PowerShell:master Jun 9, 2022
@ghost
Copy link
Copy Markdown

ghost commented Jun 22, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tab completion is unreliable in param blocks

3 participants