Update Get-Error test to not depend on DNS APIs by adityapatwardhan · Pull Request #17471 · PowerShell/PowerShell · GitHub
Skip to content

Update Get-Error test to not depend on DNS APIs#17471

Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
adityapatwardhan:UpdateGetErrorTest
Jun 3, 2022
Merged

Update Get-Error test to not depend on DNS APIs#17471
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
adityapatwardhan:UpdateGetErrorTest

Conversation

@adityapatwardhan
Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan commented Jun 2, 2022

PR Summary

Update the test to remove the dependency on DNS APIs. If the error information changes, this test should not fail which is just testing the Get-Error formatting.

PR Context

PR Checklist

@pull-request-quantifier-deprecated
Copy link
Copy Markdown

@adityapatwardhan
Copy link
Copy Markdown
Member Author

Merging this as this is blocking #17402

@adityapatwardhan adityapatwardhan merged commit d996269 into PowerShell:master Jun 3, 2022
@adityapatwardhan adityapatwardhan deleted the UpdateGetErrorTest branch June 3, 2022 16:25
@adityapatwardhan adityapatwardhan added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jun 20, 2022
@ghost
Copy link
Copy Markdown

ghost commented Jun 22, 2022

@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants