Make a variable assignment in a `ParenExpression` to return the variable value by daxian-dbw · Pull Request #17174 · PowerShell/PowerShell · GitHub
Skip to content

Make a variable assignment in a ParenExpression to return the variable value#17174

Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom
daxian-dbw:paren
Apr 22, 2022
Merged

Make a variable assignment in a ParenExpression to return the variable value#17174
daxian-dbw merged 2 commits intoPowerShell:masterfrom
daxian-dbw:paren

Conversation

@daxian-dbw
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw commented Apr 22, 2022

PR Summary

Fix #17165
Make a variable assignment in a ParenExpression to return the variable value.

PR Checklist

Comment thread src/System.Management.Automation/engine/runtime/Operations/VariableOps.cs Outdated
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 22, 2022
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 22, 2022
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

@SeeminglyScience SeeminglyScience self-requested a review April 22, 2022 17:33
Copy link
Copy Markdown
Contributor

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@daxian-dbw daxian-dbw merged commit b898da8 into PowerShell:master Apr 22, 2022
@daxian-dbw daxian-dbw deleted the paren branch April 22, 2022 17:55
@daxian-dbw daxian-dbw added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Apr 22, 2022
@ghost
Copy link
Copy Markdown

ghost commented May 23, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Passing the value of a type-constrained assignment through via the grouping operator ((...)) passes the input value rather than the converted one

3 participants