iframe-proxy

adityapatwardhan · 2022-03-23T23:05:29Z

PR Summary

During refactoring of nuget.yml for SBOM changes, creating checksum for global tool packages was missed. This change adds back creation of a checksum file for global tool packages.

PR Context

PR Checklist

pull-request-quantifier-deprecated · 2022-03-23T23:05:33Z

This PR has 21 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Small
Size       : +20 -1
Percentile : 8.4%

Total files changed: 1

Change summary by file extension:
.yml : +20 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detetcted.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

adityapatwardhan · 2022-03-23T23:06:12Z

Test build to verify the new checksum file: https://dev.azure.com/mscodehub/PowerShellCore/_build/results?buildId=250887&view=logs&j=b68f2f44-6987-572d-9dbb-1c96660ee23d&t=815f2ee4-ed58-5f9d-3b75-921a3c1e1e34&l=35

adityapatwardhan · 2022-03-23T23:07:18Z

This change should be backported to 7.0, 7.1 and 7.2. It is being marked accordingly.

PaulHigin

LGTM

PaulHigin · 2022-03-24T15:47:11Z


      Copy-Item -Path "$packagePath\SHA512SUMS" -Destination '$(System.ArtifactsDirectory)\signed\' -verbose
-      Copy-Item -Path "$packagePath\SHA512SUMS" -Destination '$(System.ArtifactsDirectory)\signed\globaltool\' -verbose
    displayName: Generate checksum file


Suggested change

displayName: Generate checksum file

displayName: Generate checksum file for packages

@adityapatwardhan Can you please address this comment? I can merge afterwards.

ghost · 2022-04-26T23:20:45Z

🎉v7.1.7 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

ghost · 2022-04-26T23:21:06Z

🎉v7.2.3 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

) Cherry-picking the checksum change: PowerShell#17056

Cherry-picking the checksum changes: 1. #15678 1. #17056

ghost · 2022-05-23T16:16:32Z

Create checksum file for global tools

9bd140a

adityapatwardhan requested review from PaulHigin, TravisEz13, anmenaga and daxian-dbw as code owners March 23, 2022 23:05

ghost assigned daxian-dbw Mar 23, 2022

pull-request-quantifier-deprecated Bot added the Extra Small label Mar 23, 2022

adityapatwardhan added BackPort-7.0.x-Consider labels Mar 23, 2022

PaulHigin approved these changes Mar 24, 2022

View reviewed changes

TravisEz13 approved these changes Mar 24, 2022

View reviewed changes

address Paul's comment

ab0daa2

daxian-dbw merged commit 23eddc9 into PowerShell:master Mar 25, 2022

daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 25, 2022

TravisEz13 added BackPort-7.0.x-Approved and removed BackPort-7.0.x-Consider labels Mar 29, 2022

daxian-dbw added Backport-7.0.x-Done Backport-7.1.x-Done Backport to 7.1.x completed Backport-7.2.x-Done and removed BackPort-7.0.x-Approved labels Apr 4, 2022

TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Apr 28, 2022

Merged PR 19935: Create checksum file for global tools (PowerShell#17056

3d0f7f0

) Cherry-picking the checksum change: PowerShell#17056

anmenaga mentioned this pull request Apr 28, 2022

Fix Generate checksum file for packages build failure #17219

Merged

22 tasks

TravisEz13 pushed a commit that referenced this pull request Apr 29, 2022

Merged PR 19934: Create checksum file for global tools

44028aa

Cherry-picking the checksum changes: 1. #15678 1. #17056

TravisEz13 mentioned this pull request May 24, 2022

Update TLS test based on current platform settings #17424

Merged

TravisEz13 mentioned this pull request Jun 7, 2022

Backport test fixes for 7.2 #17494

Merged

22 tasks

TravisEz13 mentioned this pull request Apr 16, 2024

WIP: add more detail to suspicious scriptblock logging #21475

Closed

TravisEz13 mentioned this pull request Jul 9, 2024

Add script to update SDK for release branches #24034

Merged

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create checksum file for global tools#17056

Create checksum file for global tools#17056
daxian-dbw merged 2 commits intoPowerShell:masterfrom
adityapatwardhan:GlobalToolChksum

adityapatwardhan commented Mar 23, 2022 •

edited

Loading

Uh oh!

pull-request-quantifier-deprecated Bot commented Mar 23, 2022

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

adityapatwardhan commented Mar 23, 2022

Uh oh!

adityapatwardhan commented Mar 23, 2022

Uh oh!

PaulHigin left a comment

Uh oh!

PaulHigin Mar 24, 2022

Uh oh!

daxian-dbw Mar 24, 2022

Uh oh!

ghost commented Apr 26, 2022

Uh oh!

ghost commented Apr 26, 2022

Uh oh!

ghost commented May 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	displayName: Generate checksum file
	displayName: Generate checksum file for packages

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

adityapatwardhan commented Mar 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

pull-request-quantifier-deprecated Bot commented Mar 23, 2022

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

adityapatwardhan commented Mar 23, 2022

Uh oh!

adityapatwardhan commented Mar 23, 2022

Uh oh!

PaulHigin left a comment

Choose a reason for hiding this comment

Uh oh!

PaulHigin Mar 24, 2022

Choose a reason for hiding this comment

Uh oh!

daxian-dbw Mar 24, 2022

Choose a reason for hiding this comment

Uh oh!

ghost commented Apr 26, 2022

Uh oh!

ghost commented Apr 26, 2022

Uh oh!

ghost commented May 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adityapatwardhan commented Mar 23, 2022 •

edited

Loading