Fix for Stop-Service failure with less privileged user when not setting SDDL. by kvprasoon · Pull Request #16663 · PowerShell/PowerShell · GitHub
Skip to content

Fix for Stop-Service failure with less privileged user when not setting SDDL.#16663

Merged
TravisEz13 merged 4 commits intoPowerShell:masterfrom
kvprasoon:spsv-16649
Mar 23, 2022
Merged

Fix for Stop-Service failure with less privileged user when not setting SDDL.#16663
TravisEz13 merged 4 commits intoPowerShell:masterfrom
kvprasoon:spsv-16649

Conversation

@kvprasoon
Copy link
Copy Markdown
Contributor

PR Summary

This PR is to fix bug in Stop-Service, it fails when a less privileged user tries to Set service properties using Set-Service cmdlet without using -SecurityDescriptorSddl parameter.

Fixes: #16649

PR Context

PR Checklist

Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kvprasoon Please open new issue in Docs repository to update SecurityDescriptorSddl parameter description for the scenario (what permissions users need to exclude access denied error).

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 22, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 29, 2021
@ghost
Copy link
Copy Markdown

ghost commented Dec 29, 2021

@pull-request-quantifier-deprecated
Copy link
Copy Markdown

This PR has 5 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +4 -1
Percentile : 2%

Total files changed: 1

Change summary by file extension:
.cs : +4 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@kvprasoon
Copy link
Copy Markdown
Contributor Author

kvprasoon commented Jan 29, 2022

@iSazonov @TravisEz13 @daxian-dbw anything else to be done here, are we good on this ?

@iSazonov iSazonov removed the Documentation Needed in this repo Documentation is needed in this repo label Jan 30, 2022
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 30, 2022
@ghost ghost added the Review - Needed The PR is being reviewed label Feb 7, 2022
@ghost
Copy link
Copy Markdown

ghost commented Feb 7, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Feb 7, 2022

@TravisEz13 Friendly ping.

@ghost ghost removed the Review - Needed The PR is being reviewed label Feb 7, 2022
@ghost ghost added the Review - Needed The PR is being reviewed label Feb 14, 2022
@ghost
Copy link
Copy Markdown

ghost commented Feb 14, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@TravisEz13 TravisEz13 merged commit 94eeb8e into PowerShell:master Mar 23, 2022
@ghost ghost removed the Review - Needed The PR is being reviewed label Mar 23, 2022
@ghost
Copy link
Copy Markdown

ghost commented May 23, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PWSH 7.2.1: Set-Service: Service * cannot be configured due to the following error: Access is denied.

4 participants