Fix conflicting shorthand switch `-in` for pwsh by iSazonov · Pull Request #13205 · PowerShell/PowerShell · GitHub
Skip to content

Fix conflicting shorthand switch -in for pwsh#13205

Merged
rjmholt merged 1 commit into
PowerShell:masterfrom
iSazonov:cpp-in
Jul 20, 2020
Merged

Fix conflicting shorthand switch -in for pwsh#13205
rjmholt merged 1 commit into
PowerShell:masterfrom
iSazonov:cpp-in

Conversation

@iSazonov

@iSazonov iSazonov commented Jul 17, 2020

Copy link
Copy Markdown
Collaborator

PR Summary

Conflict with -i/-interactive. New value is -inp.

PR Context

Discovered while writing tests for #11482.

The same as #12945.

PR Checklist

Conflict with `-i`/`-interactive`
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jul 17, 2020
@iSazonov iSazonov requested review from SteveL-MSFT and rjmholt July 17, 2020 17:47

@vexx32 vexx32 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good change, nice catch!

@iSazonov

Copy link
Copy Markdown
Collaborator Author

@rjmholt

rjmholt commented Jul 17, 2020

Copy link
Copy Markdown
Collaborator

@PoshChan please remind me in 24 hours

@PoshChan

Copy link
Copy Markdown
Collaborator

@rjmholt, this is the reminder you requested 24 hours ago

@rjmholt

rjmholt commented Jul 18, 2020

Copy link
Copy Markdown
Collaborator

Rerunning failed checks

@rjmholt rjmholt merged commit 8c22e5f into PowerShell:master Jul 20, 2020
@iSazonov iSazonov deleted the cpp-in branch July 21, 2020 03:39
@iSazonov iSazonov added this to the 7.1.0-preview.7 milestone Jul 21, 2020
@TravisEz13 TravisEz13 modified the milestones: 7.1.0-preview.7, 7.1.0-preview.6 Aug 5, 2020
@ghost

ghost commented Aug 17, 2020

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants