Remove component ref when regenerating the WIX file by adityapatwardhan · Pull Request #13019 · PowerShell/PowerShell · GitHub
Skip to content

Remove component ref when regenerating the WIX file#13019

Merged
adityapatwardhan merged 1 commit into
PowerShell:masterfrom
adityapatwardhan:FixWixScriptBug
Jun 23, 2020
Merged

Remove component ref when regenerating the WIX file#13019
adityapatwardhan merged 1 commit into
PowerShell:masterfrom
adityapatwardhan:FixWixScriptBug

Conversation

@adityapatwardhan

@adityapatwardhan adityapatwardhan commented Jun 23, 2020

Copy link
Copy Markdown
Member

PR Summary

When the Wix file is to be regenerated, the script was iterating through the components instead of the compenent refs. Fixed the the collection to iterate over.

PR Context

PR Checklist

@ghost ghost assigned daxian-dbw Jun 23, 2020
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jun 23, 2020

@daxian-dbw daxian-dbw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must take you guys some time to root cause this :)

@adityapatwardhan adityapatwardhan merged commit a9206d5 into PowerShell:master Jun 23, 2020
@adityapatwardhan adityapatwardhan deleted the FixWixScriptBug branch June 23, 2020 23:43
@adityapatwardhan

Copy link
Copy Markdown
Member Author

@ghost

ghost commented Jun 25, 2020

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants