Add HoloLens to list of PowerShell adopters by reynoldsbd · Pull Request #12940 · PowerShell/PowerShell · GitHub
Skip to content

Add HoloLens to list of PowerShell adopters#12940

Merged
iSazonov merged 4 commits into
PowerShell:masterfrom
reynoldsbd:hololens-adopter
Jun 17, 2020
Merged

Add HoloLens to list of PowerShell adopters#12940
iSazonov merged 4 commits into
PowerShell:masterfrom
reynoldsbd:hololens-adopter

Conversation

@reynoldsbd

Copy link
Copy Markdown
Contributor

Summary

Add information to ADOPTERS.md describing how PowerShell is used for Microsoft HoloLens development.

Checklist

@ghost ghost assigned iSazonov Jun 10, 2020
@iSazonov iSazonov added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Jun 11, 2020
Comment thread ADOPTERS.md Outdated

@SteveL-MSFT SteveL-MSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URLs should not contain the locale as it's detected by the website. Also suggest calling out PS7 specifically since HoloLens dependency is specifically PS7+

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 11, 2020

@SteveL-MSFT SteveL-MSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to add the word HoloLens to our spelling dictionary right before this line: https://github.com/PowerShell/PowerShell/blob/master/.spelling#L336

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 11, 2020
@reynoldsbd reynoldsbd requested a review from SteveL-MSFT June 11, 2020 15:34
@SteveL-MSFT

Copy link
Copy Markdown
Member

@SteveL-MSFT

Copy link
Copy Markdown
Member

@iSazonov I think we're good to merge this one

@iSazonov

Copy link
Copy Markdown
Collaborator

@SteveL-MSFT I haven't permissions to force the merging. So waiting CI-macos resolving.

@SteveL-MSFT

Copy link
Copy Markdown
Member

@iSazonov ok, I rebased this branch and that should pass CI

@iSazonov iSazonov merged commit a3319d7 into PowerShell:master Jun 17, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.4 milestone Jun 17, 2020
@ghost

ghost commented Jun 25, 2020

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants