WIP: Add empty line between single-line declarations by xtqqczze · Pull Request #12849 · PowerShell/PowerShell · GitHub
Skip to content

WIP: Add empty line between single-line declarations#12849

Closed
xtqqczze wants to merge 1 commit into
PowerShell:masterfrom
xtqqczze:RCS0012
Closed

WIP: Add empty line between single-line declarations#12849
xtqqczze wants to merge 1 commit into
PowerShell:masterfrom
xtqqczze:RCS0012

Conversation

@xtqqczze

@xtqqczze xtqqczze commented May 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

Automate fix of RCS0012

RCS0012.log

PR Context

follow-up #12824

PR Checklist

This change is Reviewable

@ghost ghost assigned daxian-dbw May 30, 2020
@xtqqczze

xtqqczze commented May 30, 2020

Copy link
Copy Markdown
Contributor Author

@xtqqczze

xtqqczze commented May 31, 2020

Copy link
Copy Markdown
Contributor Author

@iSazonov I am minded to abandon this PR unless you see a value in the changes?

Maybe I should fix 136 violations of SA1516: ElementsMustBeSeparatedByBlankLine in seperate PR?

@xtqqczze xtqqczze marked this pull request as ready for review May 31, 2020 15:32
@xtqqczze

xtqqczze commented May 31, 2020

Copy link
Copy Markdown
Contributor Author

rebased to resolve merge conflicts

TravisEz13
TravisEz13 reviewed Jun 2, 2020
View reviewed changes

@TravisEz13 TravisEz13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 67 of 452 files at r1.
Reviewable status: 67 of 452 files reviewed (waiting on @adityapatwardhan, @anmenaga, @daxian-dbw, @SteveL-MSFT, and @TravisEz13)

@TravisEz13 TravisEz13 assigned TravisEz13 and unassigned daxian-dbw Jun 2, 2020
TravisEz13
TravisEz13 reviewed Jun 2, 2020
View reviewed changes

@TravisEz13 TravisEz13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 17 of 452 files at r1.
Reviewable status: 84 of 452 files reviewed (waiting on @adityapatwardhan, @anmenaga, @daxian-dbw, @SteveL-MSFT, and @TravisEz13)

@TravisEz13 TravisEz13 added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jun 2, 2020
@TravisEz13

TravisEz13 commented Jun 2, 2020

Copy link
Copy Markdown
Member

This is way too big. Can you split into a PR of about 100 files each?
also a reviewable link would be good in a large PR like this, it let's me review one file at a time.

This hung my browser, so getting a PR this size is a horrible experience.

@xtqqczze

xtqqczze commented Jun 3, 2020

Copy link
Copy Markdown
Contributor Author

@TravisEz13 do you see value in this PR? Before you review any further, perhaps the other maintainers could weigh in on whether the changes are desirable? Compared with #12824 I think these changes are borderline.

@iSazonov

iSazonov commented Jun 3, 2020

Copy link
Copy Markdown
Collaborator

I think the change does not add value and we can ignore this.

@ghost ghost added the Review - Needed The PR is being reviewed label Jun 11, 2020
@ghost

ghost commented Jun 11, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

@xtqqczze

xtqqczze commented Jun 12, 2020

Copy link
Copy Markdown
Contributor Author

@TravisEz13 Do you think these changes add value, or not?

@adityapatwardhan

adityapatwardhan commented Jun 29, 2020

Copy link
Copy Markdown
Member

I think this does not provide enough value to accept such are large change.

@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 29, 2020
@xtqqczze

xtqqczze commented Jun 29, 2020

Copy link
Copy Markdown
Contributor Author

@xtqqczze xtqqczze closed this Jun 29, 2020
@xtqqczze xtqqczze deleted the RCS0012 branch June 29, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 left review comments
@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner
@anmenaga anmenaga Awaiting requested review from anmenaga
@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner
@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

Assignees

@TravisEz13 TravisEz13

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xtqqczze @TravisEz13 @iSazonov @adityapatwardhan @daxian-dbw