Annotating Assert methods for better code analysis by powercode · Pull Request #12618 · PowerShell/PowerShell · GitHub
Skip to content

Annotating Assert methods for better code analysis#12618

Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom
powercode:AssertAttriubute
May 11, 2020
Merged

Annotating Assert methods for better code analysis#12618
daxian-dbw merged 1 commit intoPowerShell:masterfrom
powercode:AssertAttriubute

Conversation

@powercode
Copy link
Copy Markdown
Collaborator

@powercode powercode commented May 10, 2020

PR Summary

Annotating Diagnostics.Assert with [DoesNotReturnIf(false)].

PR Context

This enables code analysis to follow the semantic checks of the asserts

PR Checklist

@ghost ghost assigned daxian-dbw May 10, 2020
@powercode powercode force-pushed the AssertAttriubute branch 2 times, most recently from 9ec97b1 to 0e8ffbc Compare May 10, 2020 19:04
@daxian-dbw daxian-dbw merged commit b003b56 into PowerShell:master May 11, 2020
@daxian-dbw daxian-dbw added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label May 11, 2020
@daxian-dbw daxian-dbw added this to the 7.1.0-preview.3 milestone May 11, 2020
powercode added a commit to powercode/PowerShell that referenced this pull request May 18, 2020
@ghost
Copy link
Copy Markdown

ghost commented May 19, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants