{{ message }}
Fix path handling bug in PSTask#12554
Merged
adityapatwardhan merged 5 commits intoMay 14, 2020
Merged
Conversation
`ForEach-Object -Parallel` should work just the same when $PWD has wildcard characters in their names
vexx32
approved these changes
May 2, 2020
vexx32
left a comment
vexx32
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, nice work!
Tests look good I think, just noticed a small style thing in one section that's really bugging me, but nothing serious. 😁
Collaborator
…bject-Parallel.Tests.ps1 Co-authored-by: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
adityapatwardhan
approved these changes
May 4, 2020
Member
|
@IISResetMe Please fix the CodeFactor issues. |
…b.com/IISResetMe/PowerShell into fix/ForEach-Object-Parallel-path-test
Collaborator
|
I think it makes no sense to merge the PR because follow more general fix will revert it - the general fix is in another place. |
Collaborator
Author
Collaborator
|
@IISResetMe Do you want to work on general fix? |
Collaborator
Author
|
Yeah I can do a broader patch for this and related behavior, but might take a few days, looks like |
Member
|
@IISResetMe Thanks for your contribution! |
adityapatwardhan
added
the
CL-Engine
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR changes the behavior PSTask to always treat the current $PWD as a literal path, in turn allowing
ForEach-Object -Parallelto execute correctly when invoked from a path with wildcard characters in the name.PR Context
Fixes #12428
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.