Document why `PackageVersion` is used in `PowerShell.Common.props` by xtqqczze · Pull Request #12523 · PowerShell/PowerShell · GitHub
Skip to content

Document why PackageVersion is used in PowerShell.Common.props#12523

Merged
TravisEz13 merged 2 commits intoPowerShell:masterfrom
xtqqczze:update-PackageVersion-csproj-comment
Apr 30, 2020
Merged

Document why PackageVersion is used in PowerShell.Common.props#12523
TravisEz13 merged 2 commits intoPowerShell:masterfrom
xtqqczze:update-PackageVersion-csproj-comment

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

PR Summary

Update documentation of why PackageVersion is used in PowerShell.Common.props.

Explanation is copied from @nguerrera comment at dotnet/sdk

PR Checklist

Add documentation of why `PackageVersion` is used in `PowerShell.Common.props`. Explamation is copied from [dotnet/sdk](dotnet/sdk#1557 (comment))

Co-Authored-By: Nick Guerrera <nicholg@microsoft.com>
Comment thread PowerShell.Common.props
@TravisEz13 TravisEz13 added the AutoMerge informs the bot to automerge the PR label Apr 29, 2020
@ghost
Copy link
Copy Markdown

ghost commented Apr 29, 2020

@TravisEz13 TravisEz13 added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Apr 29, 2020
@TravisEz13 TravisEz13 added this to the 7.1.0-preview.3 milestone Apr 29, 2020
@TravisEz13 TravisEz13 changed the title Document why PackageVersion is used in PowerShell.Common.props Document why PackageVersion is used in PowerShell.Common.props Apr 30, 2020
@TravisEz13 TravisEz13 merged commit ef1c0d7 into PowerShell:master Apr 30, 2020
@iSazonov iSazonov assigned TravisEz13 and unassigned daxian-dbw Apr 30, 2020
@xtqqczze xtqqczze deleted the update-PackageVersion-csproj-comment branch April 30, 2020 20:53
@ghost
Copy link
Copy Markdown

ghost commented May 19, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge informs the bot to automerge the PR CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants