Use dotnet strong typed resource builder by iSazonov · Pull Request #12355 · PowerShell/PowerShell · GitHub
Skip to content

Use dotnet strong typed resource builder #12355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iSazonov wants to merge 8 commits into from
Closed

Use dotnet strong typed resource builder #12355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5f12cde
Resgen.proj works
iSazonov Apr 14, 2020
5ea39a8
UI works
iSazonov Apr 14, 2020
88f22bd
Microsoft.Management.UI.Internal works
iSazonov Apr 15, 2020
35df12d
Rest csproj works
iSazonov Apr 17, 2020
94136ad
Remove ReadyToRun
iSazonov Apr 17, 2020
b7742a4
Put generated files in gen folder
iSazonov May 28, 2020
863e9bb
Remove workarround for CimCmdlets project
iSazonov Jun 15, 2020
7e7cf9a
Add link to comment
iSazonov Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion PowerShell.Common.props
View file
Open in desktop
8 changes: 4 additions & 4 deletions build.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,10 +430,10 @@ Fix steps:

# handle ResGen
# Heuristic to run ResGen on the fresh machine
if ($ResGen -or -not (Test-Path "$PSScriptRoot/src/Microsoft.PowerShell.ConsoleHost/gen")) {
Write-Log -message "Run ResGen (generating C# bindings for resx files)"
Start-ResGen
}
#if ($ResGen -or -not (Test-Path "$PSScriptRoot/src/Microsoft.PowerShell.ConsoleHost/gen")) {

@TravisEz13 TravisEz13 Apr 21, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do more clean-up or file an issue to do it

@iSazonov iSazonov Apr 21, 2020

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, after MSFT team confirm that the PR is good I will clean up all scripts.

# Write-Log -message "Run ResGen (generating C# bindings for resx files)"
# Start-ResGen
#}

# Handle TypeGen
# .inc file name must be different for Windows and Linux to allow build on Windows and WSL.
Expand Down
62 changes: 61 additions & 1 deletion src/Microsoft.Management.UI.Internal/Microsoft.PowerShell.GraphicalHost.csproj
View file
Open in desktop