Move to `.NET 5 preview.1` by SteveL-MSFT · Pull Request #12140 · PowerShell/PowerShell · GitHub
Skip to content

Move to .NET 5 preview.1#12140

Merged
TravisEz13 merged 12 commits intoPowerShell:masterfrom
SteveL-MSFT:dotnet-5
Mar 19, 2020
Merged

Move to .NET 5 preview.1#12140
TravisEz13 merged 12 commits intoPowerShell:masterfrom
SteveL-MSFT:dotnet-5

Conversation

@SteveL-MSFT
Copy link
Copy Markdown
Member

@SteveL-MSFT SteveL-MSFT commented Mar 17, 2020 •
edited
Loading

PR Summary

Updated associated build files to netcoreapp5.0 and ref assemblies to 5.0-preview.1 where applicable. Updated files.wxs to changes.

PR Checklist

@SteveL-MSFT SteveL-MSFT requested a review from daxian-dbw March 17, 2020 05:06
PoshChan
PoshChan reviewed Mar 17, 2020
View reviewed changes
Comment thread .devcontainer/Dockerfile
PoshChan
PoshChan reviewed Mar 17, 2020
View reviewed changes
Comment thread .devcontainer/Dockerfile
PoshChan
PoshChan reviewed Mar 17, 2020
View reviewed changes
Comment thread .devcontainer/Dockerfile
PoshChan
PoshChan reviewed Mar 17, 2020
View reviewed changes
Comment thread .devcontainer/Dockerfile
PoshChan
PoshChan reviewed Mar 17, 2020
View reviewed changes
Comment thread .devcontainer/Dockerfile
PoshChan
PoshChan reviewed Mar 17, 2020
View reviewed changes
Comment thread .devcontainer/Dockerfile
PoshChan
PoshChan reviewed Mar 17, 2020
View reviewed changes
Comment thread .devcontainer/Dockerfile
PoshChan
PoshChan reviewed Mar 17, 2020
View reviewed changes
Comment thread .devcontainer/Dockerfile
PoshChan
PoshChan reviewed Mar 17, 2020
View reviewed changes
Comment thread .devcontainer/Dockerfile
@Francisco-Gamino Francisco-Gamino mentioned this pull request Mar 17, 2020
Closed
@SteveL-MSFT
Copy link
Copy Markdown
Member Author

SteveL-MSFT commented Mar 17, 2020

PoshChan
PoshChan reviewed Mar 17, 2020
View reviewed changes
Comment thread .devcontainer/Dockerfile
PoshChan
PoshChan reviewed Mar 17, 2020
View reviewed changes
Comment thread .devcontainer/Dockerfile
TravisEz13
TravisEz13 reviewed Mar 17, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked at the changes so far

@TravisEz13 TravisEz13 added this to the 7.1.0-preview.1 milestone Mar 17, 2020
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 17, 2020
PoshChan
PoshChan reviewed Mar 17, 2020
View reviewed changes
Comment thread .devcontainer/Dockerfile
PoshChan
PoshChan reviewed Mar 17, 2020
View reviewed changes
Comment thread .devcontainer/Dockerfile
@SteveL-MSFT
Copy link
Copy Markdown
Member Author

SteveL-MSFT commented Mar 17, 2020

.NET 5 specifically has improvements to regex, so needed to increase the size of the DOS test

@SteveL-MSFT
Copy link
Copy Markdown
Member Author

SteveL-MSFT commented Mar 18, 2020 •
edited
Loading

On Windows, pwsh is crashing in a native API call. Opened dotnet/runtime#33703

@danmoseley
Copy link
Copy Markdown

danmoseley commented Mar 18, 2020

.NET 5 specifically has improvements to regex, so needed to increase the size of the DOS test

cc @stephentoub 👏

@danmoseley
Copy link
Copy Markdown

danmoseley commented Mar 18, 2020

It looks like there's an issue in .NET 5 preview1 where we set the main thread name and that somehow gets propagated as the process name on Linux (only)

@SteveL-MSFT is that a bug in .NET?

@SteveL-MSFT
Copy link
Copy Markdown
Member Author

SteveL-MSFT commented Mar 18, 2020 •
edited
Loading

@danmosemsft The main thread name becoming the process name is a bug in .NET and is understood (dotnet/runtime#33673). That issue isn't blocking as it's currently only affecting tests and I made changes to work around it. The crashing issue (dotnet/runtime#33703) is preventing us from moving to .NET 5. Thanks!

@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented Mar 18, 2020

There is already an issues filed for regex DOS tests: #12138

PoshChan
PoshChan reviewed Mar 19, 2020
View reviewed changes
Comment thread .devcontainer/Dockerfile
PoshChan
PoshChan reviewed Mar 19, 2020
View reviewed changes
Comment thread .devcontainer/Dockerfile
@SteveL-MSFT
Readjust webcmdlet regex test to account for perf improvement
0f8568a 
Remove assembly from startup validation
PoshChan
PoshChan reviewed Mar 19, 2020
View reviewed changes
Comment thread .devcontainer/Dockerfile
@SteveL-MSFT
Copy link
Copy Markdown
Member Author

SteveL-MSFT commented Mar 19, 2020

@PoshChan retry macos

@PoshChan
Copy link
Copy Markdown
Collaborator

PoshChan commented Mar 19, 2020

@SteveL-MSFT, successfully started retry of PowerShell-CI-macOS

TravisEz13
TravisEz13 requested changes Mar 19, 2020
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 19, 2020
@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented Mar 19, 2020

.NET originally said that the perf improvement was due to optimization, but it's actually due to a bug. I filed an issue to add it back to avoid delaying this PR.
#12155

@stephentoub
Copy link
Copy Markdown
Contributor

stephentoub commented Mar 19, 2020

.NET originally said that the perf improvement was due to optimization, but it's actually due to a bug

It's half and half :) The algorithmic complexity improved, in part due to perf improvements, and in part due to a bug fixed in Preview 2 (dotnet/runtime#33409).

@TravisEz13 TravisEz13 changed the title Move to .NET 5 preview.1 Move to .NET 5 preview.1 Mar 19, 2020
@TravisEz13 TravisEz13 merged commit 495dea0 into PowerShell:master Mar 19, 2020
@ghost
Copy link
Copy Markdown

ghost commented Mar 26, 2020

This was referenced Apr 7, 2020
Closed
Merged
@SteveL-MSFT SteveL-MSFT deleted the dotnet-5 branch June 6, 2020 02:32
@xtqqczze xtqqczze mentioned this pull request Dec 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

+1 more reviewer

@PoshChan PoshChan PoshChan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@anmenaga anmenaga

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept

Projects

None yet

Milestone

7.1.0-preview.1

Development

Successfully merging this pull request may close these issues.

6 participants

@SteveL-MSFT @danmoseley @TravisEz13 @PoshChan @stephentoub @anmenaga