{{ message }}
Update the map between console color to VT sequences#11891
Merged
adityapatwardhan merged 1 commit intoPowerShell:masterfrom Feb 20, 2020
Merged
Update the map between console color to VT sequences#11891adityapatwardhan merged 1 commit intoPowerShell:masterfrom
adityapatwardhan merged 1 commit intoPowerShell:masterfrom
Conversation
SteveL-MSFT
previously requested changes
Feb 20, 2020
Member
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Did you check the color rendering on Linux and/or macOS and Windows Terminal?
Member
Author
|
I did check on console host and win terminal, but not Linux and macOS yet. Will do that and update here. |
Member
Author
Member
|
@SteveL-MSFT Please update your review |
Member
|
LGTM. Let's merge so we can start the build |
Member
Author
|
Since I have tested it on all platforms, I'm OK to merge this PR. |
Member
|
I am OK to merge this PR. |
The task asked in the review is complete
silijon
pushed a commit
to SkyKick/PowerShell
that referenced
this pull request
Jul 2, 2020
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





PR Summary
Update the map between console color to VT sequences.
The
ConsoleColortoVT Escape Sequencesmapping inVTUtils.csis not accurate, and thus is updated according to https://docs.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences#text-formattingPowerShell/src/System.Management.Automation/utils/VTUtils.cs
Lines 25 to 43 in 895d4b3
The update is needed as "Bright foreground color" (e.g. bright red

\x1b[91m) is rendered differently fromboldcolor (e.g.\x1b[1;31m) in some front-end client, such as the Jupyter Notebook client.See the 3rd and 4th output below as an example:
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.