Correct casing for automatic variables by xtqqczze · Pull Request #11568 · PowerShell/PowerShell · GitHub
Skip to content

Correct casing for automatic variables#11568

Merged
iSazonov merged 35 commits intoPowerShell:masterfrom
xtqqczze:automatic-variables-case
Jan 14, 2020
Merged

Correct casing for automatic variables#11568
iSazonov merged 35 commits intoPowerShell:masterfrom
xtqqczze:automatic-variables-case

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented Jan 13, 2020

PR Summary

Correct casing for special variables (a.k.a. automatic variables)

PR Context

The following code was used to generate a list of special variables:

[psobject].Assembly.GetType('System.Management.Automation.SpecialVariables').GetFields('NonPublic,Static') |
    Where-Object FieldType -eq ([string]) |
    ForEach-Object GetValue $null |
    Where-Object {$_ -imatch '[a-z].+'}

PR Checklist

@ghost ghost assigned iSazonov Jan 13, 2020
@SteveL-MSFT
Copy link
Copy Markdown
Member

SteveL-MSFT commented Jan 13, 2020

@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Jan 13, 2020

@SteveL-MSFT OK, I will rewrite

@xtqqczze xtqqczze changed the title Correct casing for automatic variables [WIP]Correct casing for automatic variables Jan 13, 2020
xtqqczze added 20 commits January 13, 2020 18:36
@xtqqczze
Remove BOM, insert newline at EOF
4f5bb46
@xtqqczze
Correct case of $MyInvocation special variable
d58e1ff
@xtqqczze
Correct case of $OFS special variable
fbe459d
@xtqqczze
Correct case of $NestedPromptLevel special variable
f86f30c
@xtqqczze
Correct case of $Matches special variable
89e33f5
@xtqqczze
Correct case of $LASTEXITCODE special variable
04b292a
@xtqqczze
Correct case of $StackTrace special variable
7dd922a
@xtqqczze
Correct case of $args special variable
6663261
@xtqqczze
Correct case of $this special variable
66e0f08
@xtqqczze
Correct case of $input special variable
a051666
@xtqqczze
Correct case of $PSCmdlet special variable
42d5043
@xtqqczze
Correct case of $error special variable
b6a687b
@xtqqczze
Correct case of $PSDefaultParameterValues special variable
679702b
@xtqqczze
Correct case of $PSScriptRoot special variable
62aee93
@xtqqczze
Correct case of $PWD special variable
4a9d70f
@xtqqczze
Correct case of $null special variable
6014f4b
@xtqqczze
Correct case of $true special variable
47a3b4e
@xtqqczze
Correct case of $false special variable
bb58e2a
@xtqqczze
Correct case of $PSModuleAutoLoadingPreference special variable
9e5bb4e
@xtqqczze
Correct case of $IsLinux special variable
17d0e93
@xtqqczze xtqqczze force-pushed the automatic-variables-case branch from 698aed5 to 090ad9c Compare January 13, 2020 19:38
xtqqczze
xtqqczze commented Jan 13, 2020
View reviewed changes
Comment thread test/powershell/Host/ConsoleHost.Tests.ps1
xtqqczze
xtqqczze commented Jan 13, 2020
View reviewed changes
Comment thread test/powershell/Host/ConsoleHost.Tests.ps1
xtqqczze
xtqqczze commented Jan 13, 2020
View reviewed changes
Comment thread test/powershell/Host/ConsoleHost.Tests.ps1
xtqqczze
xtqqczze commented Jan 13, 2020
View reviewed changes
Comment thread test/powershell/engine/ParameterBinding/BooleanParameterDCR.Tests.ps1
xtqqczze
xtqqczze commented Jan 13, 2020
View reviewed changes
Comment thread test/powershell/Host/ConsoleHost.Tests.ps1
xtqqczze
xtqqczze commented Jan 13, 2020
View reviewed changes
Comment thread test/powershell/Host/ConsoleHost.Tests.ps1
xtqqczze
xtqqczze commented Jan 13, 2020
View reviewed changes
Comment thread test/powershell/Host/ConsoleHost.Tests.ps1
xtqqczze
xtqqczze commented Jan 13, 2020
View reviewed changes
Comment thread test/powershell/Language/Classes/Scripting.Classes.BasicParsing.Tests.ps1
xtqqczze
xtqqczze commented Jan 13, 2020
View reviewed changes
Comment thread test/powershell/Language/Classes/Scripting.Classes.BasicParsing.Tests.ps1
xtqqczze
xtqqczze commented Jan 13, 2020
View reviewed changes
Comment thread test/powershell/Language/Classes/Scripting.Classes.BasicParsing.Tests.ps1
@xtqqczze xtqqczze changed the title [WIP]Correct casing for automatic variables Correct casing for automatic variables Jan 13, 2020
@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Jan 13, 2020

CodeFactor issues are preexisting

@iSazonov iSazonov added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 14, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.1 milestone Jan 14, 2020
@iSazonov iSazonov merged commit aefb82a into PowerShell:master Jan 14, 2020
@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Jan 14, 2020

@iSazonov why not a squash merge?

@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented Jan 14, 2020

@iSazonov Yes please use squash commits. I've remove permissions for merge commits.

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Jan 15, 2020

GitHub did return an error after I press Squash and Merge button and show something like "Try again", then ok after refresh. :-(
Merge button was disabled some time ago but then was enabled - I don't know why.

@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Jan 22, 2020

Opened issue PowerShell/PSScriptAnalyzer#1401 to detect regressions.

@xtqqczze xtqqczze deleted the automatic-variables-case branch January 22, 2020 16:47
@ghost
Copy link
Copy Markdown

ghost commented Mar 26, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@joeyaiello joeyaiello Awaiting requested review from joeyaiello

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

Assignees

@iSazonov iSazonov

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.1

Development

Successfully merging this pull request may close these issues.

4 participants

@xtqqczze @SteveL-MSFT @TravisEz13 @iSazonov