{{ message }}
Re-add check for Invoke-Command job dispose.#11388
Merged
anmenaga merged 3 commits intoPowerShell:masterfrom Dec 20, 2019
PaulHigin:fix-session-reconnect-regression
Merged
Re-add check for Invoke-Command job dispose.#11388anmenaga merged 3 commits intoPowerShell:masterfrom PaulHigin:fix-session-reconnect-regression
anmenaga merged 3 commits intoPowerShell:masterfrom
PaulHigin:fix-session-reconnect-regression
Conversation
SteveL-MSFT
requested changes
Dec 18, 2019
Member
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Code change looks fine, possible to add a local loopback test?
Contributor
Author
SteveL-MSFT
approved these changes
Dec 18, 2019
Contributor
Author
|
Actually, I thought about this some more and have found a simpler way to test this scenario. I feel the test should be reasonably reliable and will add it here. We can always remove the test if it turns out to be fragile. |
anmenaga
approved these changes
Dec 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Summary
This fixes session reconnect regression bug: #11150.
PR Context
Invoke-Command creates a disconnected job object to facilitate session re-connection, when WinRM abruptly disconnects the session due to network issues. The EndProcessing() block was disposing the disconnected job object so that a session reconnect could not occur.
Fix is to add the checks back in the code which prevents EndProcessing() from disposing the disconnected job, and added comments explaining why the code checks are there.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.