Make suggestion system string distance algorithm case-insensitive by iSazonov · Pull Request #10549 · PowerShell/PowerShell · GitHub
Skip to content

Make suggestion system string distance algorithm case-insensitive#10549

Merged
TravisEz13 merged 2 commits intoPowerShell:masterfrom
iSazonov:make-suggestions-case-insensetive
Sep 24, 2019
Merged

Make suggestion system string distance algorithm case-insensitive#10549
TravisEz13 merged 2 commits intoPowerShell:masterfrom
iSazonov:make-suggestions-case-insensetive

Conversation

@iSazonov
Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov commented Sep 16, 2019

PR Summary

Fix #10546

PR Context

Suggestion system uses a string distance algorithm which should be case-insensitive to find command names (and file names) which have chars in different cases.

PR Checklist

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Sep 16, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.5 milestone Sep 16, 2019
@TravisEz13 TravisEz13 added the AutoMerge informs the bot to automerge the PR label Sep 16, 2019
@ghost
Copy link
Copy Markdown

ghost commented Sep 16, 2019

Comment thread src/System.Management.Automation/utils/FuzzyMatch.cs Outdated
@daxian-dbw daxian-dbw removed the AutoMerge informs the bot to automerge the PR label Sep 17, 2019
@iSazonov
Copy link
Copy Markdown
Collaborator Author

@TravisEz13 I think we can merge.

@TravisEz13
Copy link
Copy Markdown
Member

@daxian-dbw Please review again

@daxian-dbw
Copy link
Copy Markdown
Member

My concern has been addressed.

@TravisEz13 TravisEz13 merged commit 5dbaeb8 into PowerShell:master Sep 24, 2019
@iSazonov iSazonov deleted the make-suggestions-case-insensetive branch September 25, 2019 02:59
@ghost
Copy link
Copy Markdown

ghost commented Oct 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PowerShell 7 Preview 3] Typing commands with different casing returns different suggestions

4 participants