{{ message }}
Repository navigation
Correct highlight of replaced variables/splats with braces - #984
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoSep 6, 2019
Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
Dongbo Wang (daxian-dbw) merged 1 commit into
Conversation
Collaborator
Author
Prevent adjustment of userCompletionText while finding userCompletion text
position when match contains `{` in CompletionText[1] if the
userCompletionText is not longer than 1 char, and preserve the splat sigil
at start of completions of type `Variable`.
Adjusting userCompletionText blindly led to ArgumentOutOfRangeException on
incorrectly braced splats on input `@?`.
Carl Morris (msftrncs)
force-pushed
the
FixVarAndSplatBraceHighlight
branch
from
August 1, 2019 02:29
6dee015 to
70d0d34
Compare
Collaborator
Author
|
I've amended the commit for this PR. |
Member
The correction for maintaining the sigil of the returned |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
userCompletionTextinFindUserCompletionTextPositionwhen the match contains{in CompletionText[1] if theuserCompletionTextis not longer than 1 charVariable.Adjusting
userCompletionTextblindly led toArgumentOutOfRangeExceptionon incorrectly braced splats on input@?.Loss of the sigil of splats led to the splat sigil always being marked as replaced, and in situations where the PowerShell completion logic returned incorrect completions of splats with braces, led to a
ArgumentOutOfRangeException.Fix #983.