{{ message }}
Repository navigation
Improve the sensitive history scrubbing to allow retrieving token from az, gcloud, and kubectl - #3641
Merged
Conversation
…m az, gcloud, and kubectl
Andy Jordan (andyleejordan)
approved these changes
Apr 4, 2023
Andy Jordan (andyleejordan)
left a comment
Andy Jordan (andyleejordan)
left a comment
Member
There was a problem hiding this comment.
I'm ok with this but wary of the precedent it sets for us to get this right not only for these commands, but for every possible ask in the future. Like it's a nice improvement...but I could see this growing huge if we don't have a plan to decide which commands we don't scrub (and do scrub). Perhaps we should have a more general way to allow users to add exceptions?
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #3633
Improve the sensitive history scrubbing to allow retrieving token from
az,gcloud, andkubectl.The default sensitive history scrubbing was updated to handle retrieving token with gcloud, with Azure (both az cli and Az PowerShell), and with
kubectl(bothget secretanddescribe secret).PR Checklist
Microsoft Reviewers: Open in CodeFlow