iframe-proxy

Steve Lee (SteveL-MSFT) · 2026-09-25T22:43:35Z

PR Summary

remove use of unstable feature on config.toml since it's now stable
add new DscResourceKind that encapulates DscResource and DscAction, this resulted in many changes that formally only expected a DscResource
add new dsc action list to list actions, did not implement dsc action invoke since expectation is apps use the server apis
add invoke_dsc_action(), list_dsc_actions(), and show_dsc_action() server APIs
add tests for new server apis and using actions in configuration
add test actions that also cover security context and versioning
command discovery looks separately for actions and caches them separately
instead of relying on resources cache empty empty to perform discovery, add a flag since there's now 2 types of resources to be discovered

PR Context

Fix #1470

Copilot

Copilot review overview

🟡 Changes recommended

Unresolved moderate issues affect MCP contracts, input validation, configuration behavior, and discovery caching.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 6 · 1

Open (7)

What changed in this PR

Adds DSC action manifests, discovery, configuration support, CLI listing, MCP APIs, schemas, and test coverage.

Changes:

Adds action discovery, caching, invocation, and validation.
Adds dsc action list and MCP action tools.
Integrates actions with configuration and resource dispatch.
Adds fixtures, tests, localization, and stable Cargo configuration.

File	Summary
`tools/dsctest/src/main.rs`	Adds action test support and schemas.
`tools/dsctest/src/args.rs`	Adds action arguments.
`tools/dsctest/src/action.rs`	Implements test action input/output.
`tools/dsctest/dsctest.dsc.manifests.json`	Adds action manifests.
`tools/dsctest/dsctest.dsc.action.json`	Adds an action fixture.
`tools/dsctest/.project.data.json`	Includes the action fixture.
`lib/dsc-lib/src/lib.rs`	Exposes action support and resource kinds.
`lib/dsc-lib/src/extensions/dscextension.rs`	Corrects directory documentation.
`lib/dsc-lib/src/extensions/discover.rs`	Discovers action extensions.
`lib/dsc-lib/src/dscresources/dscresource.rs`	Handles resource/action distinctions.
`lib/dsc-lib/src/dscresources/command_resource.rs`	Adds action security validation.
`lib/dsc-lib/src/discovery/mod.rs`	Adds action caching and lookup; cache readiness needs correction.
`lib/dsc-lib/src/discovery/discovery_trait.rs`	Extends discovery APIs for actions.
`lib/dsc-lib/src/discovery/command_discovery.rs`	Loads action manifests; resource cache guarding needs correction.
`lib/dsc-lib/src/configure/mod.rs`	Executes actions during configuration; test/set operation selection needs correction.
`lib/dsc-lib/src/actions/mod.rs`	Registers action modules.
`lib/dsc-lib/src/actions/dscaction.rs`	Implements action loading and invocation; missing inputs can bypass validation.
`lib/dsc-lib/src/actions/action_manifest.rs`	Defines action schemas; schema transforms need alignment with resource manifests.
`lib/dsc-lib/locales/en-us.toml`	Adds action messages.
`dsc/tests/dsc_server.tests.ps1`	Tests MCP action tools.
`dsc/tests/dsc_actions.tests.ps1`	Tests action CLI and configuration behavior.
`dsc/src/subcommand.rs`	Adds action listing and validation; required null inputs and localization need correction.
`dsc/src/server/show_dsc_resource.rs`	Separates actions from resources.
`dsc/src/server/show_dsc_action.rs`	Adds action details API.
`dsc/src/server/mod.rs`	Registers action server modules.
`dsc/src/server/mcp_server.rs`	Registers action tool routers.
`dsc/src/server/list_dsc_resources.rs`	Restricts listing to resources.
`dsc/src/server/list_dsc_actions.rs`	Adds action listing; metadata incorrectly describes resources.
`dsc/src/server/invoke_dsc_resource.rs`	Restricts invocation to resources.
`dsc/src/server/invoke_dsc_action.rs`	Adds action invocation; metadata does not match the request contract.
`dsc/src/resource_command.rs`	Separates action and resource CLI operations.
`dsc/src/main.rs`	Dispatches the action subcommand.
`dsc/src/args.rs`	Defines action CLI arguments.
`dsc/locales/en-us.toml`	Adds CLI action strings.
`dsc-bicep-ext/src/main.rs`	Rejects actions in Bicep resource operations.
`.cargo/config.toml`	Removes obsolete unstable Cargo configuration.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Steve Lee (SteveL-MSFT) requested review from Mikey Lombardi (He/Him) (michaeltlombardi) and Tess Gauthier (tgauth) and a lite review from Copilot September 25, 2026 22:43

Copilot started reviewing on behalf of Steve Lee (SteveL-MSFT) September 25, 2026 22:44

View session

Copilot AI reviewed Sep 25, 2026

View reviewed changes

Steve Lee (SteveL-MSFT) marked this pull request as draft September 26, 2026 00:51

Steve Lee (SteveL-MSFT) changed the title ~~Actions~~ Add Actions type of resource Sep 28, 2026

Steve Lee (SteveL-MSFT) and others added 7 commits September 28, 2026 14:38

Add support for Actions

c1a5cf0

Implement action discovery

74165d7

implement support for actions in configure get

68e5b8f

integrate actions into engine

9cc4f48

fix loc and clippy

a9a0bec

Refactor DSC action descriptions and input validation

7a8cfc0

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

address copilot feedback

e486cd0

Steve Lee (SteveL-MSFT) force-pushed the actions branch from 8d88a05 to e486cd0 Compare September 28, 2026 21:38

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Repository navigation

Add `Actions` type of resource - #1734

Add `Actions` type of resource#1734
Steve Lee (SteveL-MSFT) wants to merge 7 commits into
PowerShell:mainfrom
SteveL-MSFT:actions

Steve Lee (SteveL-MSFT) commented Sep 25, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

Steve Lee (SteveL-MSFT) commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Steve Lee (SteveL-MSFT) commented Sep 25, 2026 •

edited

Loading