{{ message }}
Bugfix/axios webpack require#61
Merged
Merged
Conversation
…ate package with security issue
Merged
Member
Author
|
@Naramsim Sure, can you explain me how to do this? |
Member
|
I should be able to do it according to the docs: https://docs.npmjs.com/adding-dist-tags-to-packages So no action on your side |
Member
|
ok, I think I published the https://www.npmjs.com/package/pokeapi-js-wrapper?activeTab=versions @isackender , could you try and install that version? |
Contributor
@Naramsim, I just tried that and it works just fine. Here is a live demo: https://climaxmba.github.io/memory-card/. And the repo: https://github.com/climaxmba/memory-card |
Naramsim
added a commit
that referenced
this pull request
Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous PR #58 introduced issues with the built file.
This PR aim to fix this issue by changing the webpack target from
nodetowebwhich was wrongly configured and probably worked because of node polyfill included by default: https://webpack.js.org/blog/2020-10-10-webpack-5-release/#automatic-nodejs-polyfills-removedI've
npm run testandnpm run build, and everything seems to work. Then I included the built file locally in anindex.htmlfile and no more error are shown.Error
target: 'node'Success
target: 'web'