Fix/maven central portal migration by Periecle · Pull Request #765 · PlaytikaOSS/feign-reactive · GitHub
Skip to content

Fix/maven central portal migration - #765

Merged
Periecle merged 3 commits into
developfrom
fix/maven-central-portal-migration
Jun 29, 2026
Merged

Periecle merged 3 commits into
developfrom
fix/maven-central-portal-migration

Conversation

@Periecle

@Periecle Periecle commented Jun 29, 2026 •

Copy link
Copy Markdown

Summary by CodeRabbit

  • Chores
    • Added explicit project names across multiple modules and test artifacts.
    • Improved module identification in build metadata, making the project structure easier to understand in tooling and reports.

Roman Kvasnytskyi added 2 commits June 29, 2026 11:55
feign-reactor-parent forced maven-gpg-plugin to sign with gpg.keyname
3EEF24C7 and set gpg.defaultKeyring=false. Under maven-gpg-plugin 3.2.5
that combination failed to resolve the key in CI ("gpg: skipped
3EEF24C7: No secret key"), even though the org GPG_PRIVATE_KEY (which is
that key) was imported by setup-java -- the root module, which sets no
keyname, signed fine with the default key.

- Drop the hardcoded gpg.keyname/defaultKeyring (plus deprecated
  useagent/lockMode) so every module signs with the default imported
  key, matching the root module that already worked.
- Bump maven-gpg-plugin 3.2.5 -> 3.2.8 to align with the proven
  testcontainers-spring-boot release setup.
The Central Publisher Portal rejected the 5.0.0 deployment with
"Project name is missing" for every module. The Portal requires a
<name> in each published POM, and Maven does not inherit <name> from
the parent, so the 18 modules without one failed validation (only
feign-reactor-core, feign-reactor-test and the root declared a name).

Add <name>{artifactId}</name> to each remaining module, matching the
testcontainers-spring-boot convention that already publishes to the
Portal successfully.
@coderabbitai

coderabbitai Bot commented Jun 29, 2026 •

Copy link
Copy Markdown

@Periecle
Periecle merged commit 6f04efb into develop Jun 29, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant