{{ message }}
Fix missing donations & reduce unnecessary database calls#3715
Merged
Conversation
Contributor
Author
gmt2001
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
donation_idnot necessarily representing the most recent donation -> base oncreated_atfallback todonation_idStreamLabsDonationEventonly fired ifdonation_idis actually larger -> instead check each entry in the returned JSON. As we only request donations starting from the last processed one and limit the requested donations this is bound bystreamlabslimitortwitchalertslimitor5thus being negligible in terms of used CPU cyclesPhantomBot/source/com/illusionaryone/StreamLabsAPI.java
Line 108 in e7df2fd
lastIdfor a minimal increase in heap memory (worth the trade off at least in my eyes, we might even reduce the heap footprint by not creating JOOQ subordinate objects this way)