{{ message }}
Restructure alerts DOM to ensure proper positioning#3713
Merged
Conversation
gmt2001
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes image/gif alerts and text seemingly having an upper margin as they came after the
main-video-clipscontainer:Blue: video container, Yellow: alerts container, Red: text container
The new DOM structure has the video and image alerts in the same container, hiding and showing them as needed.
The PR also ensures the added alert text will always visible by dynamically enforcing a
max-heighton the media objects based on the text containers height requirement to display the passed textAdditionally this PR renames some IDs and moves classes to IDs where suited