{{ message }}
Fix Discord stream handoff in Universal mode#140
Open
Ku-Tadao wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes the Discord application-stream handoff from League Client to the in-game
League of Legends.exeprocess when Pengu Loader is activated through IFEO/Universal mode.In Universal mode, Windows starts Pengu through the IFEO
Debuggervalue asrundll32, and Pengu then creates the realLeagueClientUx.exeprocess. That makes LCUX appear as a child ofrundll32instead of Riot's normal launcher chain, which appears to break Discord's League Client -> game stream association.This PR keeps the IFEO bootstrap behavior, but when
_BootstrapEntrycreatesLeagueClientUx.exe, it usesPROC_THREAD_ATTRIBUTE_PARENT_PROCESSwith the bootstrapper's inherited parent process. In local testing this madeLeagueClientUx.exeappear under the normal RiotLeagueClient.exeprocess again instead of underrundll32.Validation
Locally validated on Windows with Discord application streaming:
LeagueClientUx.exewas parented toLeagueClient.exeinstead ofrundll32Notes
This is intentionally separate from the PluginFS PR. The local live test was also run with a combined PluginFS build so folder plugins could be validated at the same time, but the actual Discord fix is independent and only changes
core/src/dllmain.cc.This uses a documented Windows process creation attribute. It does not inject into the game process and does not change the game process. Reviewers should still treat this as a sensitive compatibility fix because anti-cheat/security tools can care about process ancestry.
Fixes #106.