Update for PSPDFKit 8.3 for iOS, PSPDFKit 3.3.0 for macOS, Xcode 10.2 and Xcode 10.2 by radazzouz · Pull Request #7 · PSPDFKit/PSPDFKitSwift · GitHub
Skip to content

Update for PSPDFKit 8.3 for iOS, PSPDFKit 3.3.0 for macOS, Xcode 10.2 and Xcode 10.2#7

Merged
radazzouz merged 6 commits into
masterfrom
rad/update-for-8.3.0
Apr 23, 2019
Merged

Update for PSPDFKit 8.3 for iOS, PSPDFKit 3.3.0 for macOS, Xcode 10.2 and Xcode 10.2#7
radazzouz merged 6 commits into
masterfrom
rad/update-for-8.3.0

Conversation

@radazzouz

@radazzouz radazzouz commented Apr 16, 2019

Copy link
Copy Markdown
Contributor

⚠️ Merge after PSPDFKit 8.3.0 stable is out ⚠️


Description:

Update PSPDFKitSwift with the latest changes from PSPDFKit 8.3.0 for iOS, PSPDFKit 3.3.0 for macOS, Xcode 10.2, and Swift 5.

Acceptance Criteria

  • Update the Rakefile
  • Update the README
  • Test CocoaPods integration on macOS
  • Test the manual/advanced integration on macOS
  • Test CocoaPods integration on iOS
  • Test the manual/advanced integration on iOS

@radazzouz radazzouz self-assigned this Apr 16, 2019
@radazzouz radazzouz added enhancement New feature or request READY TO REVIEW labels Apr 17, 2019
@OscarSwanros OscarSwanros self-requested a review April 23, 2019 18:41

@OscarSwanros OscarSwanros left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good. No warnings and integrating it works ok.

LGTM. 👍

@radazzouz radazzouz merged commit 78fd382 into master Apr 23, 2019
@radazzouz radazzouz deleted the rad/update-for-8.3.0 branch April 23, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request READY TO REVIEW

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants