Now you've expanded filepos to size_t, it makes it more obvious that the cast fseek(..., (long)filepos, ...) is rather unfortunate as well.

I think you're right that the correct unit is size_t. The fact that fseek/ftell work in longs shouldn't drive anything.

I also dislike the fact the linelength is unsigned and endlinelength is signed. That's a quite unfortunate implicit conversion for linelength + endlinelength on 32-bit systems. You don't need to fix that though, unless you want to!

I've revised my opinion!

Clearly filepos can't be correct as PCRE2_SIZE (=size_t). On a 32-bit system, you can certainly get files larger than 4GiB. It should be off_t, and there is a mess of platform macros to ensure that off_t becomes 64-bit.

If you don't feel brave enough to tackle the off_t mess in Autoconf & CMake, don't worry about it. We can merge this with a simple int64_t filepos.

Thanks for the review. Switched to int64_t and adjusted the printf format, pushed. The off_t migration sounds like its own project, happy to leave that for later.

Thanks! The first if (line_offsets) fprintf still looks like it's using mismatched types though in the format string.

See also #1024 for the future work.

Good catch, fixed that one too and pushed. Both output paths now use long long consistently.

Both of these look green now with the int64_t change and the fixed formats. Would you be ok merging when you have a moment, or is there anything else you would like changed first?