[WIP] #220 calibration#324
Conversation
to run docs without warnings
|
@alexlib Never mind, it looks like it only applies for pull requests that are capable of being merged. |
|
I have no idea. I suggest you try it in a separate branch, not in master. |
|
What is really needed here @ErichZimmer are tutorials - what are the use cases for calibration, how to use it, how to choose different models, what the user gets at the end of the story? calibrated stereo? how to use it with OpenPIV, etc. |
|
Indeed, documentation and notebooks are really important. In fact, I am currently working on a few notebooks at the moment which mainly covers the following:
As I do the notebooks, I am constantly refactoring the calibration module, though, since the only way to improve such a module is to physically use it. For instance, using Zhang's calibration method on a free-form calibration target allowed for a simple stereo-vision system to be setup where I can calculate the distance of an object in my room via triangulation. However, things have been slow for the past month or so since I unfortunately did catch a weird strain of SARS-COV-2 in addition to participating in some rather time consuming university courses. |
|
wish you a quick and full recovery. if I can help, please share with me the details. |
|
What happens on this branch? No pressure, just curiosity @ErichZimmer |
|
University got in the way. I'm taking 4 courses for credits along with 2 additional math courses every semester to help me in my studies. Right now, I am also busy for the most part on math and machine learning courses, not taking the recent tornado outbreak and associated damages into consideration.
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Alex Liberzon ***@***.***>
Sent: Sunday, April 6, 2025 2:48:22 PM
To: OpenPIV/openpiv-python ***@***.***>
Cc: Erich Zimmer ***@***.***>; Mention ***@***.***>
Subject: Re: [OpenPIV/openpiv-python] [WIP] #220 calibration (PR #324)
What happens on this branch? No pressure, just curiosity @ErichZimmer<https://github.com/ErichZimmer>
—
Reply to this email directly, view it on GitHub<#324 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQSCNNYLEOBDPIZ2HJ4XHKD2YGAINAVCNFSM6AAAAAB2SBMDQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBRGYYDSNJXGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
[alexlib]alexlib left a comment (OpenPIV/openpiv-python#324)<#324 (comment)>
What happens on this branch? No pressure, just curiosity @ErichZimmer<https://github.com/ErichZimmer>
—
Reply to this email directly, view it on GitHub<#324 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQSCNNYLEOBDPIZ2HJ4XHKD2YGAINAVCNFSM6AAAAAB2SBMDQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBRGYYDSNJXGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@ErichZimmer - have you tried to push this pull request? is it ready ? |

Preface
This quite large pull request entails the addition of a geometric camera calibration module that can be used for de-warping planar PIV images, stereo-PIV experiments, and tomo-PIV experiments. With over 25 new functions and three of the most common camera models, nearly any PIV experiment can be calibrated before further processing and reconstructions. This pull request contains the following new additions:
Along with all these new function, a large quantity of tests have been added too (more than 50 for the camera models alone). However, this module is still a work-in-progress and will be so for many weeks to months until the final product is considered production worthy.
Note
I added tomographic PIV test data in the
openpiv/data/test7directory. It is around 40 MB for this section of the dataset.Important
Documentation will have to be rebuilt once pull request is merged and a new version is released.
How to test this
What issue does this PR address?
Closes #220
Additional Context
This module is primarily for 3D imaging systems such as
However, it can also be used for
Checklist
Additionally, here is a checklist of future tasks to be completed: