{{ message }}
Repository navigation
Honor zero connect and read timeouts in the Java11 client - #3637
Open
hutiefang76 wants to merge 1 commit into
Open
hutiefang76 wants to merge 1 commit into
hutiefang76 wants to merge 1 commit into
Conversation
Omit JDK timeout setters for the documented unbounded value and match a native client with no connect timeout. Preserve positive limits and negative rejection. Fixes OpenFeign#3635
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3635.
Honor the documented
0= no timeout contract by omitting the JDK connect/request timeout setters for zero. An absent native connect timeout now matches zero options. Positive timeouts and rejection of negative values are preserved; streaming response-body timeouts (#3068) are outside this change.The real HTTP baseline had 7 zero-timeout errors and 2 passing positive controls across synchronous/asynchronous execution. All 11 regression cases now pass, including negative-value controls.
Validation: root
./mvnw -Pdev validateand./mvnw -Pdev -pl java11 -am clean verifypassed with real Zulu 8/11 main compilation and Temurin 25 tests (891 tests, 0 failures/errors, 4 existing conditional skips). License and formatting checks stayed enabled.