{{ message }}
Repository navigation
Completes async client futures when the delegate throws Error - #3630
Open
hutiefang76 wants to merge 1 commit into
Open
hutiefang76 wants to merge 1 commit into
hutiefang76 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #3629.
When a synchronous
Clientthrows anError,DefaultAsyncClientcurrently lets the executor capture it in a task future that is only used for cancellation. The separate future returned to the caller remains pending, including throughAsyncFeign. Complete that future exceptionally with the original throwable. Executor rejection, cancellation, checked/runtime exceptions and the other async adapters retain their existing behavior.Two bounded regressions cover the direct adapter and public proxy, with the same error instance asserted as the cause. IOException, runtime-exception and successful-response controls are included in the existing test class. The changelog records the fix; no API or dependency changes.
Validation:
AsyncFeignTest59 tests, 2 failures from the expected one-second timeouts; 0 errors/skips.mvn -B -Pdev -pl core clean installpasses, 777 tests, 0 failures/errors, 4 existing conditional skips. All 59 async tests pass without skips.mvn -B -Pdev validatepasses. Main sources used a real JDK 8 toolchain and tests used JDK 25. A normal checkout was used because the license plugin fails to recognize Git worktrees; license and formatting checks were retained, and the three final files were matched by SHA-256.AI assistance: DeepSeek assisted implementation and first-pass review; Codex ran and checked the reproduction, validation and final diff. Remote CI and maintainer review remain pending.