docs: Replace GPL 2+ long text with SPDX License ID across core codebase#7557
docs: Replace GPL 2+ long text with SPDX License ID across core codebase#7557ArthPatel1502 wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
pre-commit
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 11 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 18 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 12 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 10 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/lib/gis/parser_interface.c
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 22 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 22 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 15 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 72 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 20 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 20 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 7 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 7 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/lib/raster/align_window.c
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 66 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/lib/raster/color_compat.c
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/lib/raster/color_range.c
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/lib/raster/color_rule_get.c
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/lib/raster/color_shift.c
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/lib/raster/color_xform.c
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 12 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 15 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 7 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 7 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 7 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 7 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 7 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 7 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 7 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 7 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 7 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 7 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 7 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 7 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 7 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 7 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 11 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 11 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/lib/vector/Vlib/net_analyze.c
Line 11 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/lib/vector/Vlib/net_build.c
Line 11 in fe0594c
[pre-commit] reported by reviewdog 🐶
Line 11 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/lib/vector/diglib/plus.c
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/lib/vector/diglib/plus_area.c
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/lib/vector/diglib/plus_line.c
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/lib/vector/diglib/plus_node.c
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/lib/vector/diglib/type.c
Line 9 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/lib/vector/diglib/update.c
Line 11 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/raster/r.viewshed/eventlist.h
Line 33 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/raster/r.viewshed/grass.cpp
Line 33 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/raster/r.viewshed/main.cpp
Line 33 in fe0594c
[pre-commit] reported by reviewdog 🐶
grass/raster/r.viewshed/viewshed.cpp
Line 33 in fe0594c
| * (>=v2). Read the file COPYING that comes with GRASS for details. | ||
| * | ||
| * SPDX-License-Identifier: GPL-2.0-or-later | ||
| * |
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
| * | |
| * |
| * (>=v2). Read the file COPYING that comes with GRASS for details. | ||
| * | ||
| * SPDX-License-Identifier: GPL-2.0-or-later | ||
| * |
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
| * | |
| * |
| * (>=v2). Read the file COPYING that comes with GRASS for details. | ||
| * | ||
| * SPDX-License-Identifier: GPL-2.0-or-later | ||
| * |
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
| * | |
| * |
| * (>=v2). Read the file COPYING that comes with GRASS for details. | ||
| * | ||
| * SPDX-License-Identifier: GPL-2.0-or-later | ||
| * |
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
| * | |
| * |
| * (>=v2). Read the file COPYING that comes with GRASS for details. | ||
| * | ||
| * SPDX-License-Identifier: GPL-2.0-or-later | ||
| * |
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
| * | |
| * |
| * (>=v2). Read the file COPYING that comes with GRASS for details. | ||
| */ | ||
| * SPDX-License-Identifier: GPL-2.0-or-later | ||
| */ |
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
| */ | |
| */ |
| * (>=v2). Read the file COPYING that comes with GRASS for details. | ||
| * | ||
| * SPDX-License-Identifier: GPL-2.0-or-later | ||
| * |
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
| * | |
| * |
| * (>=v2). Read the file COPYING that comes with GRASS for details. | ||
| * | ||
| * SPDX-License-Identifier: GPL-2.0-or-later | ||
| * |
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
| * | |
| * |
| * (>=v2). Read the file COPYING that comes with GRASS for details. | ||
| * | ||
| * SPDX-License-Identifier: GPL-2.0-or-later | ||
| * |
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
| * | |
| * |
| * (>=v2). Read the file COPYING that comes with GRASS for details. | ||
| * | ||
| * SPDX-License-Identifier: GPL-2.0-or-later | ||
| * |
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
| * | |
| * |
echoix
left a comment
There was a problem hiding this comment.
Can you please run prek or pre commit locally before we take the time to look at 469 files changed in a same PR? Plus look at my review comment inline, wanting to understand why lines under the license text have their indentation changed
There was a problem hiding this comment.
How did you do your search&replace such as this line underneath got affected? Are they a lot of instances of this?
There was a problem hiding this comment.
@ArthPatel1502 Thanks for the work!
I agree with @echoix that lines following the original license shouldn't be touched, e.g. replacing the licence including up to "...GRASS for details." but excluding any line break.

Closes #4190. Implements an automated search-and-replace migration pattern across the codebase to cleanly substitute legacy multi-line GPL-2.0-or-later statements with inline 'SPDX-License-Identifier: GPL-2.0-or-later' declarations in-place.
Following the advice from @nilason and @echoix: