docs: Replace GPL 2+ long text with SPDX License ID across core codebase by ArthPatel1502 · Pull Request #7557 · OSGeo/grass · GitHub
Skip to content

docs: Replace GPL 2+ long text with SPDX License ID across core codebase#7557

Open
ArthPatel1502 wants to merge 3 commits into
OSGeo:mainfrom
ArthPatel1502:feature/spdx-license-cleanup-new
Open

docs: Replace GPL 2+ long text with SPDX License ID across core codebase#7557
ArthPatel1502 wants to merge 3 commits into
OSGeo:mainfrom
ArthPatel1502:feature/spdx-license-cleanup-new

Conversation

@ArthPatel1502

Copy link
Copy Markdown
Contributor

Closes #4190. Implements an automated search-and-replace migration pattern across the codebase to cleanly substitute legacy multi-line GPL-2.0-or-later statements with inline 'SPDX-License-Identifier: GPL-2.0-or-later' declarations in-place.

Following the advice from @nilason and @echoix:

  • Changes are executed in-place within the original license commentary positioning blocks.
  • Complex multi-licensed or non-standard project files have been systematically skipped for manual isolation during phase two.
  • Commits are structurally segmented by root architectural components (/lib, /db, core modules) to maximize review efficiency.
  • Formatting layout conforms completely with pre-commit line hook expectations.

@github-actions github-actions Bot added vector Related to vector data processing raster Related to raster data processing temporal Related to temporal data processing C Related code is in C C++ Related code is in C++ database Related to database management libraries module display imagery labels Jun 14, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pre-commit

[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶

* \author Original author CERL, probably Dave Gerdes or Mike


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶


[pre-commit] reported by reviewdog 🐶

Comment thread db/drivers/odbc/error.c
* (>=v2). Read the file COPYING that comes with GRASS for details.
*
* SPDX-License-Identifier: GPL-2.0-or-later
*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pre-commit] reported by reviewdog 🐶

Suggested change
*
*

Comment thread db/drivers/odbc/table.c
* (>=v2). Read the file COPYING that comes with GRASS for details.
*
* SPDX-License-Identifier: GPL-2.0-or-later
*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pre-commit] reported by reviewdog 🐶

Suggested change
*
*

* (>=v2). Read the file COPYING that comes with GRASS for details.
*
* SPDX-License-Identifier: GPL-2.0-or-later
*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pre-commit] reported by reviewdog 🐶

Suggested change
*
*

* (>=v2). Read the file COPYING that comes with GRASS for details.
*
* SPDX-License-Identifier: GPL-2.0-or-later
*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pre-commit] reported by reviewdog 🐶

Suggested change
*
*

Comment thread db/drivers/sqlite/db.c
* (>=v2). Read the file COPYING that comes with GRASS for details.
*
* SPDX-License-Identifier: GPL-2.0-or-later
*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pre-commit] reported by reviewdog 🐶

Suggested change
*
*

Comment thread lib/gis/asprintf.c
* (>=v2). Read the file COPYING that comes with GRASS for details.
*/
* SPDX-License-Identifier: GPL-2.0-or-later
*/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pre-commit] reported by reviewdog 🐶

Suggested change
*/
*/

Comment thread lib/gis/basename.c
* (>=v2). Read the file COPYING that comes with GRASS for details.
*
* SPDX-License-Identifier: GPL-2.0-or-later
*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pre-commit] reported by reviewdog 🐶

Suggested change
*
*

Comment thread lib/gis/bres_line.c
* (>=v2). Read the file COPYING that comes with GRASS for details.
*
* SPDX-License-Identifier: GPL-2.0-or-later
*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pre-commit] reported by reviewdog 🐶

Suggested change
*
*

Comment thread lib/gis/commas.c
* (>=v2). Read the file COPYING that comes with GRASS for details.
*
* SPDX-License-Identifier: GPL-2.0-or-later
*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pre-commit] reported by reviewdog 🐶

Suggested change
*
*

Comment thread lib/gis/copy_dir.c
* (>=v2). Read the file COPYING that comes with GRASS for details.
*
* SPDX-License-Identifier: GPL-2.0-or-later
*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pre-commit] reported by reviewdog 🐶

Suggested change
*
*

@echoix

echoix commented Jun 14, 2026

Copy link
Copy Markdown
Member

What's the difference between #7557 and #7556?

@echoix echoix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please run prek or pre commit locally before we take the time to look at 469 files changed in a same PR? Plus look at my review comment inline, wanting to understand why lines under the license text have their indentation changed

Comment thread db/drivers/ogr/cursor.c

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you do your search&replace such as this line underneath got affected? Are they a lot of instances of this?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArthPatel1502 Thanks for the work!

I agree with @echoix that lines following the original license shouldn't be touched, e.g. replacing the licence including up to "...GRASS for details." but excluding any line break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Related code is in C C++ Related code is in C++ database Related to database management display imagery libraries module raster Related to raster data processing temporal Related to temporal data processing vector Related to vector data processing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat] docs: adding SPDX License IDs to the source code

3 participants