{{ message }}
wxGUI/history: Handle 3D region data#7444
Open
lindakarlovska wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This adds the support for 3D region data handling in History pane. Older history records that do not store 3D values are now treated as incomplete.
Main points
2D parameters
3D parameters
If a history entry has no stored 3D params (older JSON records), the 3D parameters section shows:
Unavailable for this history entry
Region comparison now has 3 explicit states:
Here is a single screenshot with all 3 cases side by side:

Here is the original state before this PR (only 2D params and 2 explicit states for comparison of history vs current region):
