[Search DV] Display deprecation and vulnerabilities on search page. by dannyjdev · Pull Request #9440 · NuGet/NuGetGallery · GitHub
Skip to content

[Search DV] Display deprecation and vulnerabilities on search page.#9440

Merged
dannyjdev merged 12 commits into
devfrom
dev-dj-searchdep-vul
Apr 26, 2023
Merged

[Search DV] Display deprecation and vulnerabilities on search page.#9440
dannyjdev merged 12 commits into
devfrom
dev-dj-searchdep-vul

Conversation

@dannyjdev

@dannyjdev dannyjdev commented Mar 24, 2023

Copy link
Copy Markdown
Contributor

Changes

  • Retrieve Deprecation and Vulnerabilities from Search Service.
  • Added Deprecation and Vulnerabilities properties to Package.
  • Display badges on search page.

Screenshots

Vulnerable and Deprecated

Only Deprecated

Only Vulnerable

Vulnerability title

Deprecation title

Addresses

@dannyjdev dannyjdev requested a review from a team as a code owner March 24, 2023 20:48
@dannyjdev dannyjdev changed the title [D&V] Display deprecation and vulnerabilities on search page. [Search DV] Display deprecation and vulnerabilities on search page. Mar 27, 2023
Comment thread src/NuGet.Services.Entities/Package.cs Outdated
Comment thread src/NuGetGallery/Views/Shared/_ListPackage.cshtml
Comment thread src/NuGetGallery/Views/Shared/_ListPackage.cshtml

@joelverhagen joelverhagen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned about the new [NotMapped] properties on the entities.

Comment thread src/NuGetGallery/Views/Shared/_ListPackage.cshtml Outdated
Comment thread src/NuGet.Services.Entities/Package.cs Outdated
Comment thread tests/NuGetGallery.Facts/Infrastructure/Lucene/ExternalSearchServiceFacts.cs Outdated
Comment thread src/Bootstrap/less/theme/common-list-packages.less

@keylime-unicorn keylime-unicorn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I made some suggestions for the Deprecation Title.

Comment thread src/NuGetGallery/Helpers/WarningTitleHelper.cs Outdated
Comment thread src/NuGetGallery/Helpers/WarningTitleHelper.cs
Comment thread src/NuGetGallery/Helpers/WarningTitleHelper.cs
Comment thread src/NuGetGallery/Helpers/SearchResponseHelper.cs Outdated
Comment thread src/NuGetGallery/Helpers/WarningTitleHelper.cs Outdated
Comment thread src/NuGetGallery/Helpers/SearchResponseHelper.cs Outdated
Comment thread src/NuGetGallery/Helpers/SearchResponseHelper.cs
Comment thread src/NuGetGallery/Views/Shared/_ListPackage.cshtml
joelverhagen
joelverhagen previously approved these changes Apr 5, 2023
joelverhagen
joelverhagen previously approved these changes Apr 21, 2023
Comment thread src/NuGetGallery/Helpers/SearchResponseHelper.cs Outdated
Comment thread src/NuGetGallery/Helpers/SearchResponseHelper.cs
@dannyjdev dannyjdev merged commit 3ebfdea into dev Apr 26, 2023
@dannyjdev dannyjdev deleted the dev-dj-searchdep-vul branch April 26, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants