{{ message }}
Repository navigation
chore: stop dependabot proposing SixLabors majors it cannot land - #302
Merged
Merged
Conversation
ImageSharp 4 and Drawing 3 ship an MSBuild task that validates a Six Labors
license key. It degrades to a warning in Debug but fails the build outright in
Release:
SixLabors.ImageSharp.Drawing.targets(28,5): error : No Six Labors license found.
Please obtain a license from https://sixlabors.com/pricing/
The release workflow runs `dotnet build -c Release` before packing, so the major
bump cannot go green without a purchased licence, no matter what the code does.
On top of that Drawing 3 replaces the IImageProcessingContext Fill/DrawText
extensions with a stateful DrawingCanvas, which would mean rewriting every
drawing call in the test suite for no functional gain.
Pinning to the 3.x/2.x line, which is Apache-2.0 and works.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #299 and #301 — neither can be merged.
Why they cannot go green
ImageSharp 4 / Drawing 3 ship an MSBuild task that validates a Six Labors license key. It is lenient in Debug and strict in Release:
The release workflow runs
dotnet build -c Releasebeforedotnet pack, so with the bump applied:That is a purchase, not a code fix.
Separately, Drawing 3 removes the
IImageProcessingContextFill/DrawTextextension methods entirely and replaces them with a statefulDrawingCanvasbuilt from anImageFrame, takingBrush/Peninstead ofColorandRectangleinstead ofRectangleF. Every drawing call acrossTestHelper,BrushFireTests,FlowFieldTests,GoalBasedPathfinderTestsandJumpPointSearchPathfinderTestswould need rewriting — for test-only visualisation that already works.What this does
Pins the three SixLabors packages to their current major (
3.1.12/2.1.7/2.1.3, still Apache-2.0) and tells dependabot to stop opening major bumps for them, so these PRs do not reappear daily.Minor and patch updates still flow normally.
If the licence is ever bought, drop the
ignoreblock and the migration can be done deliberately.Verified:
dotnet build -c Releasesucceeds on this branch and fails with the bump applied.🤖 Generated with Claude Code
Summary by CodeRabbit