{{ message }}
Backport AxographRawIO into 0.7.x maintenance branch#682
Merged
Conversation
jpgill86
changed the title
Contributor
Author
Contributor
Author
|
I don't know why the Travis test result still shows "Pending" when it passed over 10 hours ago! As I feared, the CircleCI tests failed, just as they did before I created this PR. Sigh... 😢 |
Member
Contributor
Author
|
Thanks @apdavison for the pointers, I'll try it! |
Contributor
Author
|
#683 passed the tests. After it is merged, I'll rebase this PR onto it. |
Dependency on axographio package eliminated! Still missing multi-segment support, and there are new metadata available from AxoGraph files (events, epochs) that should be made accessible to Neo. Also need lots and lots of tests.
If read times are fast enough (especially in Python 2, perhaps because of a lower precision performance counter?), division by zero can happen when calculating speed in `benchmark_speed_read_signals `. This commit catches this problem.
jpgill86
force-pushed
the
axographrawio-backport
branch
from
44095d1 to
ad61c98
Compare
Contributor
Author
|
Ready to merge! |
Contributor
Author
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion in #670.