{{ message }}
refactor(starknet): replace BlockStatus string with typed enum#3779
Open
0xsamalt wants to merge 1 commit into
Open
refactor(starknet): replace BlockStatus string with typed enum#37790xsamalt wants to merge 1 commit into
0xsamalt wants to merge 1 commit into
Conversation
0xsamalt
commented
Jul 1, 2026
0xsamalt
commented
- Introduces BlockStatus as a typed uint8 enum in starknet/block.go with constants BlockPending, BlockAcceptedOnL1, BlockAcceptedOnL2, BlockRejected, and BlockPreConfirmed
- Adds UnmarshalText so the feeder JSON response deserialises directly into the enum and invalid status strings now return an error
- Updates all comparison sites and test assertions to use the typed constants
0xsamalt
force-pushed
the
refactor/block-status-type
branch
from
c2f22d1 to
f3415d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.