Replaced Hibernate Validator with Apache Bval by cyzhao · Pull Request #1543 · Netflix/conductor · GitHub
Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.

Replaced Hibernate Validator with Apache Bval#1543

Merged
apanicker-nflx merged 1 commit into
devfrom
replace-hibernate-validator-with-apache-bval
Feb 24, 2020
Merged

Replaced Hibernate Validator with Apache Bval#1543
apanicker-nflx merged 1 commit into
devfrom
replace-hibernate-validator-with-apache-bval

Conversation

@cyzhao

@cyzhao cyzhao commented Feb 23, 2020

Copy link
Copy Markdown
Collaborator

No description provided.

@coveralls

Copy link
Copy Markdown

@codecov

codecov Bot commented Feb 23, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1543 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1543      +/-   ##
============================================
+ Coverage     64.79%   64.98%   +0.19%     
+ Complexity     3412     3408       -4     
============================================
  Files           269      266       -3     
  Lines         15990    15978      -12     
  Branches       1442     1442              
============================================
+ Hits          10360    10383      +23     
+ Misses         4904     4869      -35     
  Partials        726      726
Impacted Files Coverage Δ Complexity Δ
...etflix/conductor/core/config/ValidationModule.java 100% <100%> (ø) 3 <1> (-3) ⬇️
...nductor/common/metadata/workflow/WorkflowTask.java 79.26% <0%> (+8.94%) 94% <0%> (+1%) ⬆️
...onductor/common/metadata/workflow/WorkflowDef.java 87.12% <0%> (+11.88%) 42% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b513405...375f8d8. Read the comment docs.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to define these constraints in a class?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, no.

@apanicker-nflx apanicker-nflx changed the base branch from master to dev February 24, 2020 18:30
@apanicker-nflx apanicker-nflx merged commit 86b2678 into dev Feb 24, 2020
@apanicker-nflx apanicker-nflx deleted the replace-hibernate-validator-with-apache-bval branch February 24, 2020 21:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants