{{ message }}
Ledger iOS support - Testers wanted#386
Draft
aleksre wants to merge 7 commits into
Draft
Conversation
aleksre
added
dependencies
Member
Author
|
Thanks for testing. Was an error message displayed? Feel free to post a screenshot. |
|
|
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: UNTESTED - Needs verification before merging.
This PR is an attempt at adding Ledger Nano S/X support for iOS and iPadOS version 13.3+ via USB.
A deployed version of the branch is available for testing here: https://nault-git-ledger-safari-support-aleksre.vercel.app/
To get this working, the
u2f-apipackage, which itself is a dependency of the deprecated@ledgerhq/hw-transport-u2flibrary, had to be force resolved to the latest version 1.2.1 with Safari support. What's more, this release seems to be bugged and fails the Safari user agent check, so I created a patch for it.In other words, quite a few hoops we had to jump through to get this (potentially) working.
In theory this should also work for MacOS Safari, but on my M1 MacBook Pro the connect button is still disabled 🤷