fix(android): list installed packages on some Samsung devices by rigor789 · Pull Request #5713 · NativeScript/nativescript-cli · GitHub
Skip to content

fix(android): list installed packages on some Samsung devices#5713

Draft
rigor789 wants to merge 1 commit intomainfrom
fix/android-list-installed-packages-samsung
Draft

fix(android): list installed packages on some Samsung devices#5713
rigor789 wants to merge 1 commit intomainfrom
fix/android-list-installed-packages-samsung

Conversation

@rigor789
Copy link
Copy Markdown
Member

@rigor789 rigor789 commented Jan 20, 2023

PR Checklist

What is the current behavior?

On some devices listing installed packages via adb shell breaks due to a permission error - and makes other parts of the CLI fail because we can't verify whether or not the app has been installed.

What is the new behavior?

In case listing the packages fails - we try an alternative (slower) method:

  • list all users
  • list all packages per user and concatenate them
  • continue with the rest of the logic...

@cla-bot cla-bot Bot added the cla: yes label Jan 20, 2023
@rigor789
Copy link
Copy Markdown
Member Author

rigor789 commented Feb 13, 2023 •
edited
Loading

@rigor789 rigor789 added this to the 8.5 milestone Mar 15, 2023
@NathanWalker NathanWalker modified the milestones: 8.5, 9.0 Oct 23, 2023
@rigor789 rigor789 removed this from the 9.0 milestone Apr 3, 2024
@neryortez
Copy link
Copy Markdown

neryortez commented Jan 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rigor789 @neryortez @NathanWalker