{{ message }}
Repository navigation
fix(asr): count VAD false alarms outside the reference extent - #16380
Open
Kayvan-Zahiri wants to merge 1 commit into
Open
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
Signed-off-by: Kayvan Zahiri <kayvanandre@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do ?
_DetectionErrorRateAccumulator(used byvad_tune_threshold_on_devandframe_vad_eval_detection_error) replaced pyannote'sDetectionErrorRatein #15632, but it undercounts false alarms. With no UEM, md-eval scores only the reference's extent, so speech predicted before the first or after the last reference segment is never counted. pyannote scored the union of the reference and hypothesis extents.Example: reference
[2, 4], hypothesis[0, 1] + [2, 4] + [5, 6]. pyannote gives FA = 2.0 s (DetER 100%). main gives FA = 0 (DetER 0%).I compared both on 1,600 random reference/hypothesis pairs, with and without overlapping segments. main disagreed with pyannote on false alarm in 1,066 of them. With this change, every pair whose reference has speech matches.
Collection: ASR
Changelog
test_detection_error_rate_counts_false_alarm_outside_reference. It fails on main and passes here.One difference remains, and it's out of scope here: a file with no reference speech is skipped by
evaluate(), so its false alarms still don't count.Checks run
pytest --cpu -m "not pleasefixme" tests/collections/asr/utils/test_vad_utils_asr.py tests/collections/speaker_tasks/utils/: 700 passed, 37 skippedpre-commit runon the changed filesNo documentation change needed.
PR Type: